Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use graphemer instead of grapheme-splitter #7069

Merged
merged 2 commits into from
Jun 28, 2023
Merged

feat: use graphemer instead of grapheme-splitter #7069

merged 2 commits into from
Jun 28, 2023

Conversation

oceandrama
Copy link
Contributor

@oceandrama oceandrama commented May 27, 2023 •
edited
Loading

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @oceandrama!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented May 27, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b37645d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/649aaeee3d420200086412d2
😎 Deploy Preview https://deploy-preview-7069--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented May 27, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b37645d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented May 27, 2023 •
edited
Loading

Codecov Report

Merging #7069 (b37645d) into main (f74862c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7069   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         386      386           
  Lines       13192    13192           
  Branches     3872     3872           
=======================================
  Hits        11534    11534           
  Misses       1292     1292           
  Partials      366      366
Flag Coverage Δ
unittest 87.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/util/getStringLength.ts 100.00% <100.00%> (ø)

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks for this!

Sorry about the delay - we've been somewhat focused on v6. But I like this PR!

@JoshuaKGoldberg JoshuaKGoldberg merged commit faea3ff into typescript-eslint:main Jun 28, 2023
json-derulo referenced this pull request in json-derulo/angular-ecmascript-intl Jul 4, 2023
@json-derulo @renovate-bot
chore(deps): update typescript-eslint monorepo to v5.61.0 (#79)
c192b03 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint)
| devDependencies | minor | [`5.60.1` ->
`5.61.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.60.1/5.61.0)
|
|
[@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint)
| devDependencies | minor | [`5.60.1` ->
`5.61.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.60.1/5.61.0)
|

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/eslint-plugin)</summary>

###
[`v5.61.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5610-2023-07-03)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.60.1...v5.61.0)

##### Features

- **eslint-plugin:** \[ban-types] ban types in extends and implements
(#&#8203[https://github.com/typescript-eslint/typescript-eslint/issues/7129](https://togithub.com/typescript-eslint/typescript-eslint/issues/7129)es/7129))
([997783f](https://togithub.com/typescript-eslint/typescript-eslint/commit/997783ff108ca18af709667ef3fdfa7134a8eefe))
- use graphemer instead of grapheme-splitter
(#&#8203;[https://github.com/typescript-eslint/typescript-eslint/issues/7069](https://togithub.com/typescript-eslint/typescript-eslint/issues/7069)s/7069))
([faea3ff](https://togithub.com/typescript-eslint/typescript-eslint/commit/faea3ff8b4d750974c41262b44db314f20d0c99c))

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

####
[5.60.1](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.60.0...v5.60.1)
(2023-06-26)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

</details>

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/parser)</summary>

###
[`v5.61.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5610-2023-07-03)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.60.1...v5.61.0)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

####
[5.60.1](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.60.0...v5.60.1)
(2023-06-26)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNTkuMyIsInVwZGF0ZWRJblZlciI6IjM1LjE1OS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Renovate Bot <bot@renovateapp.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: use graphemer instead of grapheme-splitter
2 participants
@oceandrama @JoshuaKGoldberg