feat(eslint-plugin): [restrict-plus-operands] change checkCompoundAssignments to skipCompoundAssignments #7027
Conversation
…ignments to skipCompoundAssignments
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
❌ Deploy Preview for typescript-eslint failed.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v6 #7027 +/- ##
==========================================
- Coverage 87.70% 87.69% -0.01%
==========================================
Files 372 372
Lines 12813 12813
Branches 3795 3795
==========================================
- Hits 11238 11237 -1
Misses 1199 1199
- Partials 376 377 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| allowAny?: boolean; | ||
| skipCompoundAssignments?: boolean; |
There was a problem hiding this comment.
I don't know if renaming it is overall super high value given the disruptive nature of the change. We do have precedence for "truthy-by-default" options like the options in strict-boolean-expressions.
I'll leave it up to you.
There was a problem hiding this comment.
Hmm yeah I see what you mean... I think the fact that we're turning on the behavior by default in the new config makes me feel better about it. Also not that many folks enable the option: https://sourcegraph.com/search?q=context:global+checkCompoundAssignments+lang:js+-file:node_modules&patternType=standard&sm=0&groupBy=path (current result count: 58).
JoshuaKGoldberg
deleted the
restrict-plus-operands-compound-assignments-default
branch
BREAKING CHANGE:
Renames an option for
restrict-plus-operandsPR Checklist
Overview
Renames the option, so that the default state of off means we lint
+=s.