fix(eslint-plugin): correct crashes with getTypeArguments for ts < 3.7 #6767

armano2 · 2023-03-25T08:28:59Z

PR Checklist

Steps in Contributing were taken

Overview

Tested in playground on ts 3.5.1

TypeError: e.getTypeArguments is not a function
Occurred while linting <input>:4
Rule: "@typescript-eslint/no-unsafe-argument"
    at FunctionSignature.create (https://typescript-eslint.io/sandbox/index.js:20:1047289)
    at CallExpression, NewExpression (https://typescript-eslint.io/sandbox/index.js:20:1048838)
    at https://typescript-eslint.io/sandbox/index.js:20:259967
    at https://typescript-eslint.io/sandbox/index.js:20:250486
    at Array.forEach (<anonymous>)
    at Object.emit (https://typescript-eslint.io/sandbox/index.js:20:250474)
    at NodeEventGenerator$1.applySelector (https://typescript-eslint.io/sandbox/index.js:4:122618)
    at NodeEventGenerator$1.applySelectors (https://typescript-eslint.io/sandbox/index.js:4:122920)
    at NodeEventGenerator$1.enterNode (https://typescript-eslint.io/sandbox/index.js:4:123011)
    at CodePathAnalyzer$1.enterNode (https://typescript-eslint.io/sandbox/index.js:4:56566)

no-unsafe-argument

playground main
playground this branch

/*eslint "@typescript-eslint/no-unsafe-argument": "error"*/

declare function foo(...params: [number, string, any]): void;
foo(1, 'a', 1 as any);

no-misused-promises

playground main
playground this branch

/*eslint "@typescript-eslint/no-misused-promises": "error"*/

declare function foo(...params: [number]): void;
foo(1);

require-array-sort-compare

playground main
playground this branch

/*eslint "@typescript-eslint/require-array-sort-compare": ["error", { "ignoreStringArrays": true }] */

function f(a: string[]) {
  a.sort();
}

note: type rules are not working on ts 3.3 this is most likely related to playground bug tho

ref #1752

netlify · 2023-03-25T08:29:05Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`f678b6d`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/642130e61d09360008281fad
😎 Deploy Preview	https://deploy-preview-6767--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

nx-cloud · 2023-03-25T08:32:27Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f678b6d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

codecov · 2023-03-25T08:45:03Z

Codecov Report

Merging #6767 (8f47a06) into main (f5631e9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 8f47a06 differs from pull request most recent head f678b6d. Consider uploading reports for the commit f678b6d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6767      +/-   ##
==========================================
+ Coverage   87.29%   87.33%   +0.03%     
==========================================
  Files         384      384              
  Lines       13139    13139              
  Branches     3859     3857       -2     
==========================================
+ Hits        11470    11475       +5     
+ Misses       1302     1298       -4     
+ Partials      367      366       -1

Flag	Coverage Δ
unittest	`87.33% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ges/eslint-plugin/src/rules/no-misused-promises.ts	`97.47% <100.00%> (ø)`
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts	`83.95% <100.00%> (ø)`
...int-plugin/src/rules/require-array-sort-compare.ts	`88.23% <100.00%> (ø)`
packages/type-utils/src/isTypeReadonly.ts	`88.00% <100.00%> (+2.00%)`	⬆️

... and 1 file with indirect coverage changes

bradzacher

I think that this isn't really necessary any more - we're about to merge our v6 that will bump the minimum we'll past 3.7

Also given nobody has reported this it's probably not worth adding in the inconsistency into the codebase just to fill the gap for a few weeks? WDYT?

armano2 · 2023-03-26T04:11:31Z

I think that this isn't really necessary any more - we're about to merge our v6 that will bump the minimum we'll past 3.7

Also given nobody has reported this it's probably not worth adding in the inconsistency into the codebase just to fill the gap for a few weeks? WDYT?

as we still support this in current version its better to fix this now, that have ppl ask about this in feature,

util.getTypeArguments should be removed / deprecated in v6

bradzacher · 2023-03-26T06:49:22Z

that have ppl ask about this in feature

That's kind of my point - 3.7 is 3 years old - so a lot of these have built up in the codebase over the last 3 years and I don't believe we've gotten one report about breakages.

There's some 250k weekly downloads for 3.7 versions (0.6% of the TS user base) and that number is likely dwindling. People aren't going to migrate onto 3.7 - and people that are using it certainly won't be using the latest version of our tooling.

Put another way - the intersection of people that are on the latest version of our tooling and the people that use TS3.7 is likely exactly 0.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.56.0` -> `5.57.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.56.0/5.57.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.56.0` -> `5.57.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.56.0/5.57.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.57.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5570-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5560v5570-2023-03-27) [Compare Source](typescript-eslint/typescript-eslint@v5.56.0...v5.57.0) ##### Bug Fixes - **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] simplify fixer and add support for double negation ([#6620](typescript-eslint/typescript-eslint#6620)) ([81c8519](typescript-eslint/typescript-eslint@81c8519)) - **eslint-plugin:** correct crashes with getTypeArguments for ts < 3.7 ([#6767](typescript-eslint/typescript-eslint#6767)) ([59eab58](typescript-eslint/typescript-eslint@59eab58)) ##### Features - **eslint-plugin:** \[consistent-type-assertions] add suggestions for objectLiteralTypeAssertions ([#6642](typescript-eslint/typescript-eslint#6642)) ([720e811](typescript-eslint/typescript-eslint@720e811)) - **eslint-plugin:** \[consistent-type-assertions] autofix angle bracket assertions to as ([#6641](typescript-eslint/typescript-eslint#6641)) ([ad8ea64](typescript-eslint/typescript-eslint@ad8ea64)) - **eslint-plugin:** add `no-duplicate-type-constituents` rule ([#5728](typescript-eslint/typescript-eslint#5728)) ([bc31078](typescript-eslint/typescript-eslint@bc31078)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.57.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5570-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5560v5570-2023-03-27) [Compare Source](typescript-eslint/typescript-eslint@v5.56.0...v5.57.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1831 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

fix: correct crashes with getTypeArguments for ts < 3.7

8f47a06

This comment was marked as resolved.

Sign in to view

armano2 changed the title ~~fix: correct crashes with getTypeArguments for ts < 3.7~~ fix(eslint-plugin): correct crashes with getTypeArguments for ts < 3.7 Mar 25, 2023

armano2 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Mar 25, 2023

JoshuaKGoldberg approved these changes Mar 25, 2023

View reviewed changes

bradzacher reviewed Mar 25, 2023

View reviewed changes

bradzacher approved these changes Mar 26, 2023

View reviewed changes

Merge branch 'main' into fix/crash-getTypeArguments-ts-3.7

f678b6d

armano2 merged commit 59eab58 into main Mar 27, 2023

armano2 deleted the fix/crash-getTypeArguments-ts-3.7 branch March 27, 2023 06:14

github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): correct crashes with getTypeArguments for ts < 3.7 #6767

fix(eslint-plugin): correct crashes with getTypeArguments for ts < 3.7 #6767

armano2 commented Mar 25, 2023 •

edited

Loading

This comment was marked as resolved.

netlify bot commented Mar 25, 2023 •

edited

Loading

nx-cloud bot commented Mar 25, 2023 •

edited

Loading

codecov bot commented Mar 25, 2023 •

edited

Loading

bradzacher left a comment

armano2 commented Mar 26, 2023 •

edited

Loading

bradzacher commented Mar 26, 2023

fix(eslint-plugin): correct crashes with getTypeArguments for ts < 3.7 #6767

fix(eslint-plugin): correct crashes with getTypeArguments for ts < 3.7 #6767

Conversation

armano2 commented Mar 25, 2023 • edited Loading

PR Checklist

Overview

no-unsafe-argument

no-misused-promises

require-array-sort-compare

This comment was marked as resolved.

netlify bot commented Mar 25, 2023 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Mar 25, 2023 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Mar 25, 2023 • edited Loading

Codecov Report

bradzacher left a comment

Choose a reason for hiding this comment

armano2 commented Mar 26, 2023 • edited Loading

bradzacher commented Mar 26, 2023

armano2 commented Mar 25, 2023 •

edited

Loading

netlify bot commented Mar 25, 2023 •

edited

Loading

nx-cloud bot commented Mar 25, 2023 •

edited

Loading

codecov bot commented Mar 25, 2023 •

edited

Loading

armano2 commented Mar 26, 2023 •

edited

Loading