instead of using .modifiers can we use getModifiers here?

getModifiers only returns ts.Modifier, but we need ts.Decorators, unless we call getDecorators again.

In that same file there is the getDecorators util which should do what you want I think?

I know.

unless we can call getDecorators again.

But I checked both modifiers and decorators here, and getModifiers() + getDecorators() is node.modifiers

I'm not quite sure I understand - your code below does "for each modifier, only action the decorators"

So couldn't the code be

for (const decorator of getDecorators(node)) {
  // your code
}

for (const modifier of getModifiers(node)) {
  // old code
}

Ideally, it should work, but I still can't get why you want 4 loops when you can do it in 1 loop.

Anyway, I tried, but turns out getModifiers() + getDecorators() not equals to node.modifiers.
ts.canHaveModifiers() and ts.canHaveDecorators() are stopping me to access modifiers on some node. You can try it to see the failed tests.

Should we

1. Remove those check
2. Add option to skip check

?

The problem here is that they purposely removed node.modifiers from the types in TSv5 - so we definitely don't want to be accessing it directly if we can avoid it as it's clear that their intention is for it to be a truly private property.

I guess we could add an option to skip the checks?

we can't use this function, or at least not without version checks.
in versions before 5.0 this function did not take boolean as the first argument - so by calling it like this we will cause a crash.

Given it's an internal API - I think we might want to consider rewriting it for ourselves? The logic will be pretty static given the spec doesn't change much if at all.

in versions before 5.0 this function did not take boolean as the first argument

Didn't know that.

I think we might want to consider rewriting it for ourselves?

I can try.

Added acaee6b, but I don't know the equivalent of ts.hasAmbientModifier, can you help?

hasAmbientModifier was only added in TS 4.3, and currently on v6 we are supporting 4.2
However based on the 2y lifecycle of versions that DefinitelyTyped supports (which we want to roughly align with) we will actually now be able to bump the minimum version to 4.3.

We can queue a separate PR for that then update this PR to use ts.hasAmbientModifier (#6923)

ts.hasAmbientModifier seems not available https://github.com/typescript-eslint/typescript-eslint/actions/runs/4739172024/jobs/8413765640?pr=6723#step:4:98

it's still a private, internal API!

Let's use a fake one for now? a84fa78

If we're going with a fake () => false one then I just removed it altogether. Seems like everything is working well without it? I posted a link in microsoft/TypeScript#52727 (comment).