feat(eslint-plugin): [consistent-type-assertions] add suggestions for objectLiteralTypeAssertions #6642

NotWoods · 2023-03-15T17:35:01Z

PR Checklist

Addresses an existing open issue: fixes Enhancement: [consistent-type-assertions] Suggest alternate styles for objectLiteralTypeAssertions #6607
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Suggestions changes to code styled as const x = { ... } as T;.

Suggestions:

const x: T = { ... }; // autofix for variable declarators
const x = { ... } satisfies T; // autofix for TypeScript 4.9+

typescript-eslint · 2023-03-15T17:35:03Z

Thanks for the PR, @NotWoods!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2023-03-15T17:35:06Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`25b710d`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/641a0dd1457c230008b295d7
😎 Deploy Preview	https://deploy-preview-6642--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov · 2023-03-15T17:56:51Z

Codecov Report

Merging #6642 (0fdac48) into main (f081bcd) will decrease coverage by 1.39%.
The diff coverage is n/a.

❗ Current head 0fdac48 differs from pull request most recent head 25b710d. Consider uploading reports for the commit 25b710d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6642      +/-   ##
==========================================
- Coverage   88.63%   87.24%   -1.39%     
==========================================
  Files         382      383       +1     
  Lines       12887    13083     +196     
  Branches     3789     3845      +56     
==========================================
- Hits        11422    11414       -8     
- Misses       1124     1302     +178     
- Partials      341      367      +26

Flag	Coverage Δ
unittest	`87.24% <ø> (-1.39%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

nx-cloud · 2023-03-15T18:06:42Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 25b710d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg

The core functionality change looks great to me, thanks!

Same comment as https://github.com/typescript-eslint/typescript-eslint/pull/6641/files#r1141148693 though: I worry about edge cases. Could you add some more testing around those syntax shenanigans please?

packages/eslint-plugin/src/rules/consistent-type-assertions.ts

JoshuaKGoldberg

🚀 excellent, thanks for this one too!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.56.0` -> `5.57.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.56.0/5.57.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.56.0` -> `5.57.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.56.0/5.57.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.57.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5570-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5560v5570-2023-03-27) [Compare Source](typescript-eslint/typescript-eslint@v5.56.0...v5.57.0) ##### Bug Fixes - **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] simplify fixer and add support for double negation ([#6620](typescript-eslint/typescript-eslint#6620)) ([81c8519](typescript-eslint/typescript-eslint@81c8519)) - **eslint-plugin:** correct crashes with getTypeArguments for ts < 3.7 ([#6767](typescript-eslint/typescript-eslint#6767)) ([59eab58](typescript-eslint/typescript-eslint@59eab58)) ##### Features - **eslint-plugin:** \[consistent-type-assertions] add suggestions for objectLiteralTypeAssertions ([#6642](typescript-eslint/typescript-eslint#6642)) ([720e811](typescript-eslint/typescript-eslint@720e811)) - **eslint-plugin:** \[consistent-type-assertions] autofix angle bracket assertions to as ([#6641](typescript-eslint/typescript-eslint#6641)) ([ad8ea64](typescript-eslint/typescript-eslint@ad8ea64)) - **eslint-plugin:** add `no-duplicate-type-constituents` rule ([#5728](typescript-eslint/typescript-eslint#5728)) ([bc31078](typescript-eslint/typescript-eslint@bc31078)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.57.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5570-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5560v5570-2023-03-27) [Compare Source](typescript-eslint/typescript-eslint@v5.56.0...v5.57.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1831 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

Add suggestions for objectLiteralTypeAssertions

2d55ffa

Merge branch 'main' into suggest-object-type-assertions

99a7e03

bradzacher added the enhancement New feature or request label Mar 15, 2023

JoshuaKGoldberg requested changes Mar 20, 2023

View reviewed changes

packages/eslint-plugin/src/rules/consistent-type-assertions.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Mar 20, 2023

NotWoods added 3 commits March 20, 2023 10:00

Add additional test cases

0806103

Capture parentheses

a81e39f

Use changes from other PR

0fdac48

NotWoods requested a review from JoshuaKGoldberg March 20, 2023 20:38

Merge branch 'main' into suggest-object-type-assertions

e3fd84a

JoshuaKGoldberg removed the awaiting response Issues waiting for a reply from the OP or another party label Mar 21, 2023

Merge branch 'main'

25b710d

JoshuaKGoldberg approved these changes Mar 21, 2023

View reviewed changes

JoshuaKGoldberg merged commit 720e811 into typescript-eslint:main Mar 21, 2023

NotWoods deleted the suggest-object-type-assertions branch March 21, 2023 20:27

github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): [consistent-type-assertions] add suggestions for objectLiteralTypeAssertions #6642

feat(eslint-plugin): [consistent-type-assertions] add suggestions for objectLiteralTypeAssertions #6642

NotWoods commented Mar 15, 2023

typescript-eslint bot commented Mar 15, 2023

netlify bot commented Mar 15, 2023 •

edited

Loading

codecov bot commented Mar 15, 2023 •

edited

Loading

nx-cloud bot commented Mar 15, 2023 •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

feat(eslint-plugin): [consistent-type-assertions] add suggestions for objectLiteralTypeAssertions #6642

feat(eslint-plugin): [consistent-type-assertions] add suggestions for objectLiteralTypeAssertions #6642

Conversation

NotWoods commented Mar 15, 2023

PR Checklist

Overview

typescript-eslint bot commented Mar 15, 2023

netlify bot commented Mar 15, 2023 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

codecov bot commented Mar 15, 2023 • edited Loading

Codecov Report

nx-cloud bot commented Mar 15, 2023 • edited Loading

☁️ Nx Cloud Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

netlify bot commented Mar 15, 2023 •

edited

Loading

codecov bot commented Mar 15, 2023 •

edited

Loading

nx-cloud bot commented Mar 15, 2023 •

edited

Loading