Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: mention re-requesting PR reviews #6493

Merged
merged 2 commits into from
Mar 1, 2023
Merged

docs: mention re-requesting PR reviews #6493

merged 2 commits into from
Mar 1, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds a mention about re-requesting review with a link to the GitHub docs. This way it's not ambiguous whether folks should wait for us.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 19, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f8e501c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 19, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f8e501c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63f59db836f5c60008327514
😎 Deploy Preview https://deploy-preview-6493--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Feb 22, 2023 •
edited
Loading

Codecov Report

Merging #6493 (f8e501c) into main (16144d1) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6493      +/-   ##
==========================================
- Coverage   90.66%   90.66%   -0.01%     
==========================================
  Files         374      376       +2     
  Lines       12823    12851      +28     
  Branches     3777     3783       +6     
==========================================
+ Hits        11626    11651      +25     
- Misses        853      856       +3     
  Partials      344      344
Flag Coverage Δ
unittest 90.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/consistent-generic-constructors.ts 90.69% <0.00%> (-4.18%) ⬇️
packages/type-utils/src/containsAllTypesByName.ts 0.00% <0.00%> (ø)
.../eslint-plugin/src/rules/promise-function-async.ts 98.07% <0.00%> (ø)
packages/typescript-estree/src/clear-caches.ts 100.00% <0.00%> (ø)
...ript-estree/src/create-program/describeFilePath.ts 100.00% <0.00%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts 91.66% <0.00%> (+0.36%) ⬆️
...ipt-estree/src/parseSettings/resolveProjectList.ts 91.48% <0.00%> (+0.37%) ⬆️
...-estree/src/create-program/createProjectProgram.ts 97.67% <0.00%> (+4.19%) ⬆️

@bradzacher bradzacher merged commit e37ebfe into typescript-eslint:main Mar 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IronGeek IronGeek IronGeek left review comments

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Mention re-requesting review in Contributing > Pull Requests
3 participants
@JoshuaKGoldberg @IronGeek @bradzacher