Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint-plugin): [prefer-optional-chain] fix incorrect syntax in documentation #5172

Merged
merged 1 commit into from
Jun 12, 2022
Merged

chore(eslint-plugin): [prefer-optional-chain] fix incorrect syntax in documentation #5172

merged 1 commit into from
Jun 12, 2022

Conversation

PythonCoderAS
Copy link
Contributor

PR Checklist

Overview

Fixes invalid syntax.

> (((foo || {}).a || {}).b {}).c;
(((foo || {}).a || {}).b {}).c;
                         ^

Uncaught SyntaxError: Unexpected token '{'

Now has become:

> (((foo || {}).a || {}).b || {}).c;
undefined

@nx-cloud
Copy link

nx-cloud bot commented Jun 12, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 856208f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @PythonCoderAS!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jun 12, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 856208f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62a5cf77dbea3e0009f7e777
😎 Deploy Preview https://deploy-preview-5172--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 12, 2022 •
edited
Loading

Codecov Report

Merging #5172 (856208f) into main (78af93b) will increase coverage by 2.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5172      +/-   ##
==========================================
+ Coverage   91.33%   93.82%   +2.49%     
==========================================
  Files         132      287     +155     
  Lines        1488     9862    +8374     
  Branches      224     2950    +2726     
==========================================
+ Hits         1359     9253    +7894     
- Misses         65      329     +264     
- Partials       64      280     +216
Flag Coverage Δ
unittest 93.82% <ø> (+2.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/padding-line-between-statements.ts 93.83% <0.00%> (ø)
...src/rules/naming-convention-utils/parse-options.ts 100.00% <0.00%> (ø)
...ages/eslint-plugin/src/rules/default-param-last.ts 100.00% <0.00%> (ø)
...lugin/src/rules/indent-new-do-not-use/TokenInfo.ts 100.00% <0.00%> (ø)
...eslint-plugin/src/rules/no-unsafe-member-access.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/array-type.ts 97.18% <0.00%> (ø)
packages/eslint-plugin/src/rules/await-thenable.ts 100.00% <0.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-qualifier.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/comma-spacing.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/brace-style.ts 95.34% <0.00%> (ø)
... and 145 more

@armano2 armano2 changed the title Fix incorrect syntax chore(website): fix incorrect syntax Jun 12, 2022
@armano2 armano2 changed the title chore(website): fix incorrect syntax chore(eslint-plugin): [prefer-optional-chain] fix incorrect syntax in documentation Jun 12, 2022
@armano2 armano2 added documentation Documentation ("docs") that needs adding/updating package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Jun 12, 2022
@JoshuaKGoldberg JoshuaKGoldberg merged commit b67b6e4 into typescript-eslint:main Jun 12, 2022
@PythonCoderAS PythonCoderAS deleted the patch-1 branch June 12, 2022 15:29
@Josh-Cena
Copy link
Member

chore(eslint-plugin): [prefer-optional-chain] fix incorrect syntax in documentation

Um, really, this should be a docs commit, not a chore

@armano2
Copy link
Member

armano2 commented Jun 12, 2022

ahh my mistake xd

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PythonCoderAS @Josh-Cena @armano2 @JoshuaKGoldberg