Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump dependencies #4952

Merged
merged 6 commits into from
May 10, 2022
Merged

chore: bump dependencies #4952

merged 6 commits into from
May 10, 2022

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented May 10, 2022

Bump all of our dependency versions including ones we couldn't auto-bump


I believe the coverage drop is from the jest upgrade


The outdated packages after this PR:

% yarn outdated
yarn outdated v1.22.17
info Color legend : 
 "<red>"    : Major Update backward-incompatible updates 
 "<yellow>" : Minor Update backward-compatible features 
 "<green>"  : Patch Update backward-compatible bug fixes
Package                            Current       Wanted        Latest        Workspace                                 Package Type    URL                                          
@docusaurus/core                   2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme
@docusaurus/module-type-aliases    2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   devDependencies https://github.com/facebook/docusaurus#readme
@docusaurus/plugin-content-docs    2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme
@docusaurus/plugin-content-pages   2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme
@docusaurus/plugin-debug           2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme
@docusaurus/remark-plugin-npm2yarn 2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme
@docusaurus/theme-classic          2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme
@docusaurus/theme-common           2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme
@docusaurus/theme-search-algolia   2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme
@mdx-js/react                      1.6.22        1.6.22        2.1.1         website                                   dependencies    https://mdxjs.com                            
cypress                            8.3.0         8.3.0         9.6.1         website                                   devDependencies https://github.com/cypress-io/cypress        
downlevel-dts                      0.9.0         0.9.0         0.10.0        @typescript-eslint/typescript-eslint      devDependencies https://github.com/sandersn/downlevel-dts    
eslint-scope                       5.1.1         5.1.1         7.1.1         @typescript-eslint/utils                  dependencies    http://github.com/eslint/eslint-scope        
globby                             11.1.0        11.1.0        13.1.1        @typescript-eslint/typescript-estree      dependencies    https://github.com/sindresorhus/globby#readme
globby                             11.1.0        11.1.0        13.1.1        website                                   devDependencies https://github.com/sindresorhus/globby#readme
prettier                           2.5.1         2.5.1         2.6.2         @typescript-eslint/typescript-eslint      devDependencies https://prettier.io                          
prettier                           2.5.1         2.6.2         2.6.2         @typescript-eslint/eslint-plugin-internal dependencies    https://prettier.io                          
prettier                           2.5.1         2.6.2         2.6.2         @typescript-eslint/eslint-plugin          devDependencies https://prettier.io                          
prettier                           2.5.1         2.6.2         2.6.2         @typescript-eslint/scope-manager          devDependencies https://prettier.io 
  • prettier i'll do in a separate PR as it'll require a format run
  • globby we can't bump because it's switched to ESM
  • eslint-scope can't be updated without a major - Utils: remove eslint-scope types #4953
  • downlevel-dts has a bug in the new version - [bug] type parameter names are stripped erroneously leading to broken code sandersn/downlevel-dts#77
  • The following are all website packages which I'll leave for now - Josh / Armano / etc can upgrade if they feel the need. It's all majors so it'll probs take effort / code knowledge I don't have 😄.
    • @docusaurus/core, @docusaurus/module-type-aliases, @docusaurus/plugin-content-docs, @docusaurus/plugin-content-pages, @docusaurus/plugin-debug, @docusaurus/remark-plugin-npm2yarn, @docusaurus/theme-classic, @docusaurus/theme-common, @docusaurus/theme-search-algolia, @mdx-js/react, cypress

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label May 10, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 10, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d43f7d5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented May 10, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d43f7d5
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/627ae698d7ff810008c5a48d
😎 Deploy Preview https://deploy-preview-4952--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #4952 (d43f7d5) into main (7275977) will decrease coverage by 2.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4952      +/-   ##
==========================================
- Coverage   94.25%   91.78%   -2.47%     
==========================================
  Files         153      228      +75     
  Lines        8305    10633    +2328     
  Branches     2702     3289     +587     
==========================================
+ Hits         7828     9760    +1932     
- Misses        263      591     +328     
- Partials      214      282      +68     
Flag Coverage Δ
unittest 91.78% <ø> (-2.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin/src/rules/naming-convention-utils/format.ts 83.33% <ø> (ø)
packages/utils/src/ast-utils/predicates.ts 95.55% <0.00%> (ø)
packages/utils/src/ast-utils/index.ts 25.00% <0.00%> (ø)
packages/type-utils/src/predicates.ts 36.23% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/Definition.ts 100.00% <0.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts 91.30% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts 84.32% <0.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts 89.79% <0.00%> (ø)
packages/eslint-plugin-tslint/src/rules/config.ts 97.29% <0.00%> (ø)
...gin-internal/src/rules/no-poorly-typed-ts-props.ts 88.88% <0.00%> (ø)
... and 66 more

@bradzacher bradzacher force-pushed the update-deps-2022-05-09 branch from 615c44c to 5db85b3 Compare May 10, 2022 04:08
@bradzacher bradzacher marked this pull request as ready for review May 10, 2022 04:26
@@ -155,8 +154,8 @@ jobs:
flags: unittest
name: codecov

linting_and_style:
name: Code style and lint
spellcheck:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split this out just because i was annoyed when one failed and it killed the entire lint job.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me on the splitup!

...and continued irk at GHA for not making it easy to reuse steps copypasta...

@@ -0,0 +1,2 @@
# see comment in the file
packages/ast-spec/tests/util/parsers/typescript-estree-import.ts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesHenry - the new version of nx started reporting circular deps, so I had to add this hack back in.

"@types/node": "^16.11.4",
"typescript": "4.6.2"
"@types/node": "^17.0.31",
"pretty-format": "^28.1.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of the jest packages depends on the old pretty-format version which was breaking the types.

jest-util "27.2.0"
jest-config "27.5.1"
jest-resolve "27.5.1"
jest-util "27.5.1"
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grr, @nrwl/jest claims to rely on fixed specific versions of Jest 27 but seems to in fact support Jest 28. Maybe there's an issue for us to file?

This root dependency is the only reason I can find for all the jest@27 versions to still be installed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can use yarn to pin the version to 28 across the repo!

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

dunno if this'll break anything - but worth a shot.
lets see what the Ci signal shows!
@bradzacher bradzacher merged commit 1fc4e76 into main May 10, 2022
@bradzacher bradzacher deleted the update-deps-2022-05-09 branch May 10, 2022 23:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants