-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump dependencies #4952
chore: bump dependencies #4952
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #4952 +/- ##
==========================================
- Coverage 94.25% 91.78% -2.47%
==========================================
Files 153 228 +75
Lines 8305 10633 +2328
Branches 2702 3289 +587
==========================================
+ Hits 7828 9760 +1932
- Misses 263 591 +328
- Partials 214 282 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
|
615c44c
to
5db85b3
Compare
@@ -155,8 +154,8 @@ jobs: | |||
flags: unittest | |||
name: codecov | |||
|
|||
linting_and_style: | |||
name: Code style and lint | |||
spellcheck: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split this out just because i was annoyed when one failed and it killed the entire lint job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me on the splitup!
...and continued irk at GHA for not making it easy to reuse steps copypasta...
@@ -0,0 +1,2 @@ | |||
# see comment in the file | |||
packages/ast-spec/tests/util/parsers/typescript-estree-import.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JamesHenry - the new version of nx started reporting circular deps, so I had to add this hack back in.
"@types/node": "^16.11.4", | ||
"typescript": "4.6.2" | ||
"@types/node": "^17.0.31", | ||
"pretty-format": "^28.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one of the jest packages depends on the old pretty-format version which was breaking the types.
jest-util "27.2.0" | ||
jest-config "27.5.1" | ||
jest-resolve "27.5.1" | ||
jest-util "27.5.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grr, @nrwl/jest
claims to rely on fixed specific versions of Jest 27 but seems to in fact support Jest 28. Maybe there's an issue for us to file?
This root dependency is the only reason I can find for all the jest@27 versions to still be installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can use yarn to pin the version to 28 across the repo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
dunno if this'll break anything - but worth a shot. lets see what the Ci signal shows!
Bump all of our dependency versions including ones we couldn't auto-bump
I believe the coverage drop is from the jest upgrade
The outdated packages after this PR:
prettier
i'll do in a separate PR as it'll require a format runglobby
we can't bump because it's switched to ESMeslint-scope
can't be updated without a major - Utils: removeeslint-scope
types #4953downlevel-dts
has a bug in the new version - [bug] type parameter names are stripped erroneously leading to broken code sandersn/downlevel-dts#77@docusaurus/core
,@docusaurus/module-type-aliases
,@docusaurus/plugin-content-docs
,@docusaurus/plugin-content-pages
,@docusaurus/plugin-debug
,@docusaurus/remark-plugin-npm2yarn
,@docusaurus/theme-classic
,@docusaurus/theme-common
,@docusaurus/theme-search-algolia
,@mdx-js/react
,cypress