feat(eslint-plugin): [no-empty-function] new allow option overrideMethods #4923

Josh-Cena · 2022-05-07T06:20:13Z

PR Checklist

Addresses an existing open issue: fixes [no-empty-function] Allow empty functions for overridden class functions #4919
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

…hods

nx-cloud · 2022-05-07T06:20:14Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 55de5c7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2022-05-07T06:20:18Z

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

netlify · 2022-05-07T06:20:19Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`55de5c7`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/627d1e4a5f5dc0000c9e2981
😎 Deploy Preview	https://deploy-preview-4923--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov · 2022-05-07T06:32:23Z

Codecov Report

Merging #4923 (55de5c7) into main (77e15a9) will increase coverage by 1.60%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #4923      +/-   ##
==========================================
+ Coverage   92.64%   94.24%   +1.60%     
==========================================
  Files         190      153      -37     
  Lines       10251     8309    -1942     
  Branches     3249     2704     -545     
==========================================
- Hits         9497     7831    -1666     
+ Misses        502      263     -239     
+ Partials      252      215      -37

Flag	Coverage Δ
unittest	`94.24% <75.00%> (+1.60%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...kages/eslint-plugin/src/rules/no-empty-function.ts	`79.48% <75.00%> (-0.52%)`	⬇️
...gin-internal/src/rules/no-poorly-typed-ts-props.ts
packages/type-utils/src/getContextualType.ts
...ges/typescript-estree/src/create-program/shared.ts
...internal/src/rules/no-typescript-default-import.ts
...t-estree/src/create-program/useProvidedPrograms.ts
packages/type-utils/src/getTokenAtPosition.ts
...plugin-internal/src/rules/prefer-ast-types-enum.ts
packages/typescript-estree/src/ast-converter.ts
...ges/type-utils/src/getConstrainedTypeAtLocation.ts
... and 28 more

JoshuaKGoldberg

💯 looks great, and the docs match up with the existing style. Thanks!

packages/eslint-plugin/src/rules/no-empty-function.ts

Josh-Cena · 2022-05-16T10:58:38Z

packages/eslint-plugin/docs/rules/no-empty-function.md

@@ -28,7 +28,8 @@ This rule adds the following options:
 type AdditionalAllowOptionEntries =
  | 'private-constructors'
  | 'protected-constructors'
-  | 'decoratedFunctions';
+  | 'decoratedFunctions'
+  | 'overrideMethods';


Question before merge: should we go with camel case or kebab case? ESLint always uses kebab case, and so are the two other options here.

i don't think it hugely matters - I think we use a mix of everything in this codebase.
we can always write a lint rule and standardise later!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.23.0` -> `5.25.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.23.0/5.25.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.23.0` -> `5.25.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.23.0/5.25.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.25.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5240v5250-2022-05-17) [Compare Source](typescript-eslint/typescript-eslint@v5.24.0...v5.25.0) ##### Bug Fixes - **eslint-plugin:** \[typedef] stop enforcing rule for assignment expressions ([#4958](typescript-eslint/typescript-eslint#4958)) ([04a216c](typescript-eslint/typescript-eslint@04a216c)) - **eslint-plugin:** strict config should not extend recommended ([#5005](typescript-eslint/typescript-eslint#5005)) ([05d71c2](typescript-eslint/typescript-eslint@05d71c2)) - **website:** correct Presets link to be Configs ([#5004](typescript-eslint/typescript-eslint#5004)) ([e18e91c](typescript-eslint/typescript-eslint@e18e91c)) ##### Features - **eslint-plugin:** \[no-empty-function] new allow option overrideMethods ([#4923](typescript-eslint/typescript-eslint#4923)) ([13c05ae](typescript-eslint/typescript-eslint@13c05ae)) - **eslint-plugin:** deprecate `no-duplicate-imports` in favour of `import/no-duplicates` ([#4973](typescript-eslint/typescript-eslint#4973)) ([1d2e41a](typescript-eslint/typescript-eslint@1d2e41a)) - update to TypeScript 4.7-rc ([#4829](typescript-eslint/typescript-eslint#4829)) ([6fe783c](typescript-eslint/typescript-eslint@6fe783c)) ### [`v5.24.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5230v5240-2022-05-16) [Compare Source](typescript-eslint/typescript-eslint@v5.23.0...v5.24.0) ##### Bug Fixes - **eslint-plugin:** \[array-type] in fixer add missing parens for constructor types [#4756](typescript-eslint/typescript-eslint#4756) ([#4971](typescript-eslint/typescript-eslint#4971)) ([0377070](typescript-eslint/typescript-eslint@0377070)) ##### Features - **eslint-plugin:** Add BigInt object type to default ban-types list ([#4970](typescript-eslint/typescript-eslint#4970)) ([1867728](typescript-eslint/typescript-eslint@1867728)) - **eslint-plugin:** add new 'strict' config ([#4706](typescript-eslint/typescript-eslint#4706)) ([4a500b2](typescript-eslint/typescript-eslint@4a500b2)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.25.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5240v5250-2022-05-17) [Compare Source](typescript-eslint/typescript-eslint@v5.24.0...v5.25.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) ### [`v5.24.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5230v5240-2022-05-16) [Compare Source](typescript-eslint/typescript-eslint@v5.23.0...v5.24.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1357 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

feat(eslint-plugin): [no-empty-function] new allow option overrideMet…

e3b0d3d

…hods

bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label May 10, 2022

JoshuaKGoldberg previously approved these changes May 12, 2022

View reviewed changes

packages/eslint-plugin/src/rules/no-empty-function.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg dismissed their stale review via 12fff1d May 12, 2022 14:48

JoshuaKGoldberg added 2 commits May 12, 2022 10:48

Update packages/eslint-plugin/src/rules/no-empty-function.ts

12fff1d

Merge branch 'main' into allow-empty-override

55de5c7

JoshuaKGoldberg enabled auto-merge (squash) May 12, 2022 14:48

JoshuaKGoldberg approved these changes May 12, 2022

View reviewed changes

Josh-Cena commented May 16, 2022

View reviewed changes

bradzacher disabled auto-merge May 16, 2022 17:19

bradzacher merged commit 13c05ae into typescript-eslint:main May 16, 2022

Josh-Cena deleted the allow-empty-override branch May 17, 2022 01:45

github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): [no-empty-function] new allow option overrideMethods #4923

feat(eslint-plugin): [no-empty-function] new allow option overrideMethods #4923

Josh-Cena commented May 7, 2022

nx-cloud bot commented May 7, 2022 •

edited

Loading

typescript-eslint bot commented May 7, 2022

netlify bot commented May 7, 2022 •

edited

Loading

codecov bot commented May 7, 2022 •

edited

Loading

JoshuaKGoldberg left a comment

Josh-Cena May 16, 2022

bradzacher May 16, 2022

feat(eslint-plugin): [no-empty-function] new allow option overrideMethods #4923

feat(eslint-plugin): [no-empty-function] new allow option overrideMethods #4923

Conversation

Josh-Cena commented May 7, 2022

PR Checklist

Overview

nx-cloud bot commented May 7, 2022 • edited Loading

☁️ Nx Cloud Report

typescript-eslint bot commented May 7, 2022

netlify bot commented May 7, 2022 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

codecov bot commented May 7, 2022 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Josh-Cena May 16, 2022

Choose a reason for hiding this comment

bradzacher May 16, 2022

Choose a reason for hiding this comment

nx-cloud bot commented May 7, 2022 •

edited

Loading

netlify bot commented May 7, 2022 •

edited

Loading

codecov bot commented May 7, 2022 •

edited

Loading