fix(eslint-plugin): [no-restricted-imports] allow type import as long as there's one matching pattern #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as there's one matching pattern
|
Thanks for the PR, @Josh-Cena! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #4898 +/- ##
==========================================
+ Coverage 91.76% 94.25% +2.49%
==========================================
Files 226 153 -73
Lines 10586 8300 -2286
Branches 3280 2700 -580
==========================================
- Hits 9714 7823 -1891
+ Misses 591 263 -328
+ Partials 281 214 -67
Flags with carried forward coverage won't be shown. Click here to find out more. |
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
May 13, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.22.0` -> `5.23.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.22.0/5.23.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.22.0` -> `5.23.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.22.0/5.23.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.23.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5230-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5220v5230-2022-05-09) [Compare Source](typescript-eslint/typescript-eslint@v5.22.0...v5.23.0) ##### Bug Fixes - **eslint-plugin:** \[no-restricted-imports] allow type import as long as there's one matching pattern ([#​4898](typescript-eslint/typescript-eslint#4898)) ([0419d28](typescript-eslint/typescript-eslint@0419d28)) - **eslint-plugin:** \[no-unnecessary-type-constraint] change to suggestion fix, fix multiple trailing comma failures ([#​4901](typescript-eslint/typescript-eslint#4901)) ([4507ac8](typescript-eslint/typescript-eslint@4507ac8)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.23.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5230-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5220v5230-2022-05-09) [Compare Source](typescript-eslint/typescript-eslint@v5.22.0...v5.23.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1345 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
allowTypeImportsbreak validation #4895Overview
The problem with our current logic is that we require every allowed import pattern to match a given path, but in practice, they can well be disjoint! With this change, we will be more permissive and allow type import as long as one matcher matches.
This may lead to some false-negatives? For example, there are two matchers that both match a file, one with
allowTypeImports, another without. Previously, we report an error; now we don't. To be fair, both seem like valid behaviors to me. We don't have existing test-cases covering that anyways, and it doesn't seem like we have this behavior specced in the docs, so I assume either is fine.