Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add missing comma in CUSTOM_RULES.md #4464

Merged
merged 3 commits into from
Jan 24, 2022
Merged

docs: Add missing comma in CUSTOM_RULES.md #4464

merged 3 commits into from
Jan 24, 2022

Conversation

zaicevas
Copy link
Contributor

PR Checklist

Overview

I think the PR title and content is self-explanatory

@nx-cloud
Copy link

nx-cloud bot commented Jan 20, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit a4dc161. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @zaicevas!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jan 20, 2022 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: a4dc161

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61eddee795c47a00086e86df

😎 Browse the preview: https://deploy-preview-4464--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Jan 20, 2022 •
edited
Loading

Codecov Report

Merging #4464 (21c9ce1) into main (8894106) will increase coverage by 1.84%.
The diff coverage is n/a.

❗ Current head 21c9ce1 differs from pull request most recent head a4dc161. Consider uploading reports for the commit a4dc161 to get more accurate results

@@            Coverage Diff             @@
##             main    #4464      +/-   ##
==========================================
+ Coverage   92.70%   94.54%   +1.84%     
==========================================
  Files         183      147      -36     
  Lines        9759     7851    -1908     
  Branches     3054     2516     -538     
==========================================
- Hits         9047     7423    -1624     
+ Misses        480      234     -246     
+ Partials      232      194      -38
Flag Coverage Δ
unittest 94.54% <ø> (+1.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin-internal/src/rules/prefer-ast-types-enum.ts
packages/type-utils/src/typeFlagUtils.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/type-utils/src/getTokenAtPosition.ts
...-estree/src/create-program/createProjectProgram.ts
packages/typescript-estree/src/convert.ts
...ript-estree/src/create-program/createSourceFile.ts
packages/type-utils/src/isUnsafeAssignment.ts
...-estree/src/create-program/createDefaultProgram.ts
packages/typescript-estree/src/ts-estree/index.ts
... and 26 more

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 nice find, thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) January 23, 2022 22:19
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Jan 24, 2022
@bradzacher bradzacher disabled auto-merge January 24, 2022 02:20
@bradzacher bradzacher merged commit d8256b7 into typescript-eslint:main Jan 24, 2022
lonyele pushed a commit to lonyele/typescript-eslint that referenced this pull request Feb 12, 2022
@zaicevas @JoshuaKGoldberg @lonyele
docs: Add missing comma in CUSTOM_RULES.md (typescript-eslint#4464)
1c87eea 
* Add missing comma in docs

* chore: ran Prettier

Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg <joshuakgoldberg@outlook.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaicevas @JoshuaKGoldberg @bradzacher