-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(website): add playground to website #4108
chore(website): add playground to website #4108
Conversation
This comment has been minimized.
This comment has been minimized.
✔️ Deploy Preview for typescript-eslint ready! 🔨 Explore the source changes: e66e0a0 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61a4a28da2a6310065ee5260 😎 Browse the preview: https://deploy-preview-4108--typescript-eslint.netlify.app |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@Josh-Cena fixed |
one feature request to add to the todo later list for this: we should add a panel where you can view the "fix" output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you merge main in then it should fix the linter oom as well
added to https://github.com/orgs/typescript-eslint/projects/3/views/1 |
We should talk to / learn from the TS folks with respect to their multi-file playground. I know they added it for their Halloween event and want to enable it more broadly. It'd be good for more complex repros down the line. (Obv not part of this PR) |
Fix up the lint errors and then we can merge this in 😃 |
fixed |
not sure why nx is failing here on netlify, looks like its cache issue @bradzacher any ideas? |
https://github.com/armano2/typescript-eslint/blob/website-playground/workspace.json I think you need to add the package here? I don't know much about the setup tho. James is the expert with it |
but |
@JamesHenry might have an idea of what's causing the above crash? |
@bradzacher @armano2 Fixed! I didn't bother to look into the specific error too deeply because it was occurring when building all projects as part of the postinstall process. That is repeated work for us because we already do that in the GitHub Actions and so I instead figured out how to skip the postinstall within the Netlify build. I just had to set the Thanks so much again for your great work on this @armano2! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I just used this to inspect the AST for TS 4.5 import/export specifier kinds so I could build scope analysis support. Such a HUGE win here. I'm so happy you built this with AST support! |
Overview
Migrated version of playground from #3147
Fixes #168
TODO: