fix(parser): fix crash when visiting decorators in parameters #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
changed the title
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=========================================
+ Coverage 94.53% 94.6% +0.07%
=========================================
Files 63 63
Lines 2761 2762 +1
Branches 718 719 +1
=========================================
+ Hits 2610 2613 +3
Misses 57 57
+ Partials 94 92 -2
|
armano2
changed the title
8 tasks
bradzacher
approved these changes
Feb 12, 2019
|
Crash is related to eslint not beeing able to set parent to decorators in parameters. eslint traverse nodes base on structure defined in visitor-keys, and setts up parent for nodes. no-unused-vars is relying on parent of nodes set properly 2nd issue was that TSParameterProperty was not visitable and rule itself was reporting unused variables bacause we was not making references for decorators |
JamesHenry
approved these changes
Feb 12, 2019
kaicataldo
pushed a commit
to kaicataldo/typescript-eslint
that referenced
this pull request
Aug 27, 2019
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixes crashes in no-unused-vars for decorators in non identifier function parameters, and fixes issue with no-shadow for
thisin functions#122 (comment)
i think we should merge this after #234 (snapshots for scope analysis)
fixes: #207