refactor(parser): add ast types to parser #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
commented
Feb 4, 2019
armano2
commented
Feb 4, 2019
armano2
commented
Feb 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 96.57% 96.66% +0.08%
==========================================
Files 51 52 +1
Lines 2455 2459 +4
Branches 370 370
==========================================
+ Hits 2371 2377 +6
+ Misses 42 41 -1
+ Partials 42 41 -1
|
armano2
commented
Feb 4, 2019
| @@ -214,7 +220,7 @@ class Referencer extends OriginalReferencer { | |||
| this.visit(node.superTypeParameters); | |||
| } | |||
| if (node.implements) { | |||
| this.visit(node.implements); | |||
| node.implements.forEach(this.visit, this); | |||
There was a problem hiding this comment.
this is actual issue, implements in classes is a array of nodes but visit expect that you provide node iteslf
i have to design a way to test visiting
scope analysis snapshots does not contain information about implements, its part of "type scope", and its not yet implemented
see #19
armano2
added
blocked by another PR
|
let me know when this is in a state you'd like a review! |
|
i aligned it with your changes to |
JamesHenry
requested changes
Feb 6, 2019
|
You need to do the rename in each file though, you are creating multiple
names symbols for the same thing in different places.
With my suggestion you could do the same refactor step on one single symbol
which would be imported by name everywhere
…On Tue, 5 Feb 2019 at 20:58, Armano ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/typescript-estree/src/parser.ts
<#205 (comment)>
:
> @@ -14,8 +14,8 @@ import ts from 'typescript';
import convert from './ast-converter';
import { convertError } from './convert';
import { firstDefined } from './node-utils';
-import * as es from './typedefs';
-import { Extra, ParserOptions } from './parser-options';
+import * as TSESTree from './typedefs';
i renames all es to TSEStree, i'm unsure what editor you are using but in
Intelij its
right click -> refactor -> rename -> and its done xd
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#205 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA29qxqPtTRd3syWAUQ5W4whnPBntm9Xks5vKjbegaJpZM4agcOV>
.
|
|
^ Whoops added the above comment via email and it didn’t link it to your comment above |
JamesHenry
approved these changes
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.