Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): added new rule unbound-method #204

Merged
merged 14 commits into from
Apr 3, 2019
Merged

feat(eslint-plugin): added new rule unbound-method #204

merged 14 commits into from
Apr 3, 2019

Conversation

JoshuaKGoldberg
Copy link
Member

Adds the equivalent of TSLint's no-unbound-method rule.

Josh Goldberg added 2 commits February 3, 2019 16:57
feat(eslint-plugin): added new rule no-unbound-method
dd263d4 
Adds the equivalent of TSLint's `no-unbound-method` rule.
Merge branch 'master'
f9e2176
@codecov
Copy link

codecov bot commented Feb 3, 2019 •
edited
Loading

Codecov Report

Merging #204 into master will decrease coverage by <.01%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage    97.2%   97.19%   -0.01%     
==========================================
  Files          68       69       +1     
  Lines        2507     2534      +27     
  Branches      388      392       +4     
==========================================
+ Hits         2437     2463      +26     
  Misses         44       44              
- Partials       26       27       +1
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/unbound-method.ts 96.29% <96.29%> (ø)

@armano2 armano2 added the enhancement: new plugin rule New rule request for eslint-plugin label Feb 4, 2019
JamesHenry
JamesHenry requested changes Feb 6, 2019
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job overall, just the one weird typo

packages/eslint-plugin/docs/rules/no-unbound-method.md Outdated Show resolved Hide resolved
JamesHenry
JamesHenry previously approved these changes Feb 7, 2019
View reviewed changes
bradzacher
bradzacher previously approved these changes Feb 7, 2019
View reviewed changes
@bradzacher bradzacher mentioned this pull request Feb 7, 2019
Merged
@JamesHenry
Copy link
Member

Apologies for the conflicts, we decided to remove the counts from the ROADMAP here: #225

They are too awkward to maintain manually, so this is the last time you will have to deal with syncing that up!

@bradzacher bradzacher dismissed stale reviews from JamesHenry and themself via 30035e8 February 7, 2019 03:47
bradzacher
bradzacher previously approved these changes Feb 7, 2019
View reviewed changes
JamesHenry
JamesHenry previously approved these changes Feb 7, 2019
View reviewed changes
@bradzacher
Copy link
Member

Hey @JoshuaKGoldberg, sorry for the pain, but we just merged a big PR to convert the plugin to typescript.
Please have a look through the source code and migrate your PR to typescript as well.
Let me know if you've got any questions!

@bradzacher bradzacher dismissed stale reviews from JamesHenry and themself February 11, 2019 18:08

needs ts conversion

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat(eslint-plugin): added new rule no-unbound-method feat(eslint-plugin): added new rule unbound-method Feb 18, 2019
@JoshuaKGoldberg
Copy link
Member Author

Whoohoo, TypeScript conversion! Absolutely more than worth the PR churn. 😄

Well, the build looks like it partially failed from DevOps flickering for a moment. Linting and formatting passes locally.

I'll try to get to the other PRs soon!™

JamesHenry
JamesHenry previously requested changes Feb 23, 2019
View reviewed changes
packages/eslint-plugin/src/rules/unbound-method.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg
Copy link
Member Author

Ping @j-f1 (since you commented most recently) - is there anything I'm being waited on for this?

@j-f1 j-f1 requested a review from JamesHenry March 13, 2019 14:57
bradzacher
bradzacher previously approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoshuaKGoldberg
Copy link
Member Author

👋 @bradzacher is there something that needs to be done? I'd very much like to help migrate more rules from tslint to typescript-eslint but this and my other two PRs have been sitting for a while. 😢

@JamesHenry
Copy link
Member

JamesHenry commented Apr 3, 2019 •
edited
Loading

Sorry for the slow process on some of your PRs @JoshuaKGoldberg - as soon as the merge conflicts are resolved, we'll get this in!

JamesHenry
JamesHenry previously approved these changes Apr 3, 2019
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg dismissed stale reviews from JamesHenry and bradzacher via dcd2d45 April 3, 2019 13:20
@JamesHenry JamesHenry merged commit 6718906 into typescript-eslint:master Apr 3, 2019
@JamesHenry
Copy link
Member

Thanks again, @JoshuaKGoldberg!

@JoshuaKGoldberg JoshuaKGoldberg deleted the typescript-eslint-no-unbound-method branch April 3, 2019 18:47
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull request Aug 27, 2019
@armano2 @JamesHenry
[FEAT] Add tool to generate recommended config (typescript-eslint#204)
0a858be
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-f1 j-f1 j-f1 left review comments

@mysticatea mysticatea mysticatea left review comments

@sindresorhus sindresorhus sindresorhus left review comments

@JamesHenry JamesHenry JamesHenry approved these changes

@bradzacher bradzacher bradzacher left review comments

Assignees
No one assigned
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JoshuaKGoldberg @JamesHenry @bradzacher @sindresorhus @mysticatea @j-f1 @armano2