Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ts-estree): fix issue with nested jsx tag names #197

Merged
merged 3 commits into from
Feb 4, 2019
Merged

fix(ts-estree): fix issue with nested jsx tag names #197

merged 3 commits into from
Feb 4, 2019

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Feb 3, 2019 •
edited
Loading

Changes:

  • fix issue with nested jsx tag names <a.b.c.d.e.f.g>
  • simplify conversion and determining if node is jsx tag name
  • make sure that jsx tag names are added to tsNodeToESTreeNodeMap and esTreeNodeToTSNodeMap

@armano2 armano2 added bug Something isn't working blocked by another PR PRs which are ready to go but waiting on another PR labels Feb 3, 2019
@armano2 armano2 self-assigned this Feb 3, 2019
@armano2
fix(ts-estree): simplify conversion of jsx tag names to ast
0c73f1f 
make sure that nodes are correctly added to node maps
@armano2 armano2 removed the blocked by another PR PRs which are ready to go but waiting on another PR label Feb 3, 2019
@codecov
Copy link

codecov bot commented Feb 3, 2019 •
edited
Loading

Codecov Report

Merging #197 into master will increase coverage by 0.51%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #197      +/-   ##
=========================================
+ Coverage   95.68%   96.2%   +0.51%     
=========================================
  Files          51      51              
  Lines        2458    2449       -9     
  Branches      372     368       -4     
=========================================
+ Hits         2352    2356       +4     
+ Misses         65      48      -17     
- Partials       41      45       +4
Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 96.8% <100%> (+2.2%) ⬆️
packages/typescript-estree/src/node-utils.ts 95.36% <0%> (-1.04%) ⬇️

@armano2
Copy link
Member Author

armano2 commented Feb 3, 2019

i'm going to add tests for tsNodeToESTreeNodeMap and esTreeNodeToTSNodeMap

@armano2 armano2 changed the title fix(ts-estree): simplify conversion of jsx tag names to ast fix(ts-estree): fix issue with nested jsx tag names Feb 3, 2019
@armano2 armano2 requested a review from JamesHenry February 3, 2019 22:38
@JamesHenry JamesHenry merged commit e37a1ed into typescript-eslint:master Feb 4, 2019
@armano2 armano2 deleted the jsx-names branch February 4, 2019 15:29
@armano2 armano2 mentioned this pull request Feb 13, 2019
Merged
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull request Aug 27, 2019
@weirdpattern @JamesHenry
[CHORE] Gix husky configuration (typescript-eslint#197)
87606b9
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees

@armano2 armano2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @JamesHenry