Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [typedef] add variable-declaration-ignore-function #1578

Merged
merged 3 commits into from
Feb 29, 2020
Merged

feat(eslint-plugin): [typedef] add variable-declaration-ignore-function #1578

merged 3 commits into from
Feb 29, 2020

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Feb 7, 2020 •
edited by bradzacher
Loading

Fixes #1555

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Feb 7, 2020
@codecov
Copy link

codecov bot commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #1578 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1578      +/-   ##
==========================================
+ Coverage   95.53%   95.53%   +<.01%     
==========================================
  Files         142      142              
  Lines        6626     6628       +2     
  Branches     1897     1898       +1     
==========================================
+ Hits         6330     6332       +2     
  Misses        106      106              
  Partials      190      190
Impacted Files Coverage Δ
...plugin/src/rules/explicit-module-boundary-types.ts 86.2% <100%> (+0.49%) ⬆️

bradzacher
bradzacher approved these changes Feb 29, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing this!

@bradzacher bradzacher merged commit fc0a55e into typescript-eslint:master Feb 29, 2020
This was referenced Mar 9, 2020
Merged
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 25, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[typedef] variable-declaration-ignore-function from TSLint not implemented
2 participants
@a-tarasyuk @bradzacher