-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript-estree): hash code to reduce update frequency #1179
Conversation
Thanks for the PR, @yoyo930021! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
a7c2313
to
aca1c0e
Compare
We need to look at another solution for Vue SFC is slow. |
Test result:
PS. The tested project is https://github.com/typescript-eslint/vega-lite. |
aca1c0e
to
6f6422a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT. two minor nits
Thanks for this
packages/typescript-estree/src/create-program/createWatchProgram.ts
Outdated
Show resolved
Hide resolved
packages/typescript-estree/src/create-program/createWatchProgram.ts
Outdated
Show resolved
Hide resolved
Cannot wait to have this merged, my built time is drastically quicker and node cpu is much lower using this change. Thanks 🎉 |
6f6422a
to
02c227f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this
FWIW, (presumably this fix in) 2.7.0 brought time to lint a ~2000 file, 90% TS / 10% JS project from 10 minutes to 2. Awesome fix, thank you so much! 🚀 |
try to fix #1132