Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo: Require PRs that change config presets to be marked as breaking changes #6890

Closed
JoshuaKGoldberg opened this issue Apr 12, 2023 · 0 comments · Fixed by #9243
Closed

Repo: Require PRs that change config presets to be marked as breaking changes #6890

JoshuaKGoldberg opened this issue Apr 12, 2023 · 0 comments · Fixed by #9243
Assignees
@JoshuaKGoldberg
Labels
locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs team assigned A member of the typescript-eslint team should work on this.

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Our Configurations and Maintenance > Versioning docs specify that changes to the recommended configs need to be marked as a breaking change. But nothing I can spot enforces that changes to recommended.ts or its friends be labeled as breaking change.

To help prevent slipups in the future, let's add some kind of automation that marks PRs as failing if they do touch a recommended config file and don't have the breaking change label.
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs and removed triage Waiting for team members to take a look labels Apr 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 12, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg removed their assignment Apr 16, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the accepting prs Go ahead, send a pull request that resolves this issue label Apr 16, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jun 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg added team assigned A member of the typescript-eslint team should work on this. and removed accepting prs Go ahead, send a pull request that resolves this issue labels Jun 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 4, 2024
Merged
3 tasks
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Jun 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs team assigned A member of the typescript-eslint team should work on this.
Projects
None yet
Milestone
No milestone
1 participant
@JoshuaKGoldberg