Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support eslint@6 #645

Merged
merged 7 commits into from
Jul 21, 2019
Merged

feat: Support eslint@6 #645

merged 7 commits into from
Jul 21, 2019

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Jun 25, 2019 •
edited
Loading

There was some weirdness around now requiring absolute paths for parser in test, but otherwise seemed to "just work"

BREAKING: dropped support for node 6

Fixes #644
Fixes #564

@bradzacher bradzacher added enhancement New feature or request dependencies Issue about dependencies of the package labels Jun 25, 2019
@bradzacher bradzacher requested a review from JamesHenry June 25, 2019 02:54
@codecov

This comment has been minimized.

Sign in to view
@bradzacher
Copy link
Member Author

hmmmm this is going to be a breaking change technically, as we'll have to drop support for node v6 to run tests, unless we want to do some funky stuff with tests...

@platinumazure
Copy link
Contributor

For what it's worth, Node 6 is fully unsupported/end-of-life even by the Node team at this point.

@jhpratt

This comment has been minimized.

Sign in to view
@bradzacher

This comment has been minimized.

Sign in to view
@jhpratt

This comment has been minimized.

Sign in to view
@bradzacher

This comment has been minimized.

Sign in to view
@jhpratt

This comment has been minimized.

Sign in to view
@trivikr

This comment has been minimized.

Sign in to view
@bradzacher

This comment has been minimized.

Sign in to view
@dependabot-preview dependabot-preview bot mentioned this pull request Jun 27, 2019
Closed
@bradzacher bradzacher mentioned this pull request Jun 28, 2019
Closed
@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Jun 28, 2019
@bradzacher bradzacher added this to the 2.0.0 milestone Jun 28, 2019
@bradzacher bradzacher mentioned this pull request Jul 17, 2019
Merged
This was referenced Jul 20, 2019
Closed
Closed
@JamesHenry JamesHenry merged commit 34a7cf6 into master Jul 21, 2019
@JamesHenry JamesHenry deleted the eslint-6 branch July 21, 2019 17:24
@tamuratak tamuratak mentioned this pull request Aug 22, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package enhancement New feature or request
Projects
None yet
Milestone
2.0.0
5 participants
@bradzacher @platinumazure @jhpratt @trivikr @JamesHenry