Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo: Enable one-var internally #6405

Closed
JoshuaKGoldberg opened this issue Jan 31, 2023 · 0 comments · Fixed by #6410
Closed

Repo: Enable one-var internally #6405

JoshuaKGoldberg opened this issue Jan 31, 2023 · 0 comments · Fixed by #6410
Labels
accepting prs Go ahead, send a pull request that resolves this issue good first issue Good for newcomers repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

https://eslint.org/docs/latest/rules/one-var

Specifically, let's enable one-var's never option?
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Jan 31, 2023
@bradzacher bradzacher added good first issue Good for newcomers accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Feb 1, 2023
sviat9440 pushed a commit to MillerSvt/typescript-eslint that referenced this issue Feb 2, 2023
chore: enable one-var rule typescript-eslint#6405
bbf8df3
@sviat9440 sviat9440 mentioned this issue Feb 2, 2023
Merged
3 tasks
sviat9440 added a commit to MillerSvt/typescript-eslint that referenced this issue Feb 2, 2023
@sviat9440
chore: enable one-var rule typescript-eslint#6405
4719493
sviat9440 added a commit to MillerSvt/typescript-eslint that referenced this issue Feb 2, 2023
@sviat9440
chore: enable one-var rule typescript-eslint#6405
cc14694
JoshuaKGoldberg pushed a commit that referenced this issue Feb 2, 2023
@sviat9440
chore: enable one-var rule (#6410)
a948729 
chore: enable one-var rule #6405
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue good first issue Good for newcomers repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: enable one-var rule MillerSvt/typescript-eslint
2 participants
@JoshuaKGoldberg @bradzacher