feat(typescript-estree): added allowInvalidAST option to not throw on invalid tokens #6247
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v6 #6247 +/- ##
==========================================
- Coverage 87.81% 87.72% -0.09%
==========================================
Files 365 365
Lines 12455 12479 +24
Branches 3669 3679 +10
==========================================
+ Hits 10937 10947 +10
- Misses 1158 1170 +12
- Partials 360 362 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I'm not so sure this is the right approach to fixing the issue. It'd be hard to add branching logic for every possible syntactic issue not reported as such by TypeScript. Instead, I'll look at using our isolated program to catch them. Let this PR serve as a reference for what this logic could look like. 🙂 Edit: the isolated program is too slow. We're going with this! 🚀 |
...ges/ast-spec/src/declaration/ClassDeclaration/fixtures/_error_/export-missing-name/config.ts
Outdated
Show resolved
Hide resolved
bradzacher
added
the
awaiting response
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
removed
the
awaiting response
JoshuaKGoldberg
requested review from
bradzacher
and removed request for
bradzacher
PR Checklist
Overview
Adds an opt-in
allowInvalidASToption to@typescript-eslint/typescript-estreeand@typescript-eslint/parser. It enables checks for some known cases where TypeScript reports a syntactic issue as semantic:no-restricted-exports: Cannot read property 'name' of null eslint/eslint#15384)indentthrows TypeError: Cannot read property 'loc' of undefined eslint/eslint#14538)Note that some previously reported cases seem to now be reported as syntactic issues by TypeScript:
export(Results of weekly scheduled smoke test jsx-eslint/eslint-plugin-react#3178)import(Parsing: strictly enforce the produced AST matches the spec and enforce most "error recovery" parsing errors #1852 (comment))throw(Handle throw with no arguments in no-throw-literal eslint/eslint#13143)Does not tackle more difficult cases:
asyncinside a non-async function ([Bug]awaiton non-async function does not throw an error #2997)abstractmembers markedasync(TypeScript 4.1 Syntax Support #2583 (comment))inon a primitive (TypeScript 4.2 Syntax Support #2935 (comment))MethodDefinition(readonlyanddeclareinvalid property forMethodDefinition. #2908 (comment))