Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: resolving base config errors when enabling new strict preset #5001

Closed
4 tasks done
FloEdelmann opened this issue May 17, 2022 · 4 comments · Fixed by #5005
Closed
4 tasks done

Bug: resolving base config errors when enabling new strict preset #5001

FloEdelmann opened this issue May 17, 2022 · 4 comments · Fixed by #5005
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working

Comments

@FloEdelmann
Copy link
Contributor

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Issue Description

When enabling the new strict config, ESLint fails with the following error:

Oops! Something went wrong! :(

ESLint: 8.15.0

ESLint couldn't find the config "./configs/base" to extend from. Please check that the name of the config is correct.

The config "./configs/base" was referenced from the config file in "/home/flo/www/vue-ts-types/node_modules/@typescript-eslint/eslint-plugin/dist/configs/recommended.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

See also FloEdelmann/vue-ts-types#29 and https://github.com/FloEdelmann/vue-ts-types/runs/6472350066?check_suite_focus=true

I first tried enabling the config like described here: https://github.com/typescript-eslint/typescript-eslint/blob/v5.24.0/docs/linting/CONFIGS.md#strict

(N.B.: The link "presets" on this rules docs page doesn't work: https://typescript-eslint.io/rules/)

Since the strict config extends from the recommended and recommended-with-type-info configs, I deleted them from my own ESLint config, but the error persisted in both cases.

Reproduction Repository Link

https://github.com/FloEdelmann/vue-ts-types/tree/strict-eslint

Repro Steps

  1. clone the repo
  2. git switch strict-eslint
  3. npm install
  4. npm run lint

Versions

package version
@typescript-eslint/eslint-plugin 5.24.0
@typescript-eslint/parser 5.24.0
TypeScript 4.6.4
ESLint 8.15.0
node 14.19.2
@FloEdelmann FloEdelmann added bug Something isn't working triage Waiting for team members to take a look labels May 17, 2022
@FloEdelmann FloEdelmann mentioned this issue May 17, 2022
Merged
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this May 17, 2022
This was referenced May 17, 2022
Closed
Merged
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels May 17, 2022
@JoshuaKGoldberg
Copy link
Member

Eek, thanks for filing. I can repro on a new project. Looking now. Probably a side effect of #4706. I didn't think that PR changed any of this logic... 🤔

@JoshuaKGoldberg
Copy link
Member

Ok, I see the issue: it's that I'd had strict extend from recommended and recommended-requiring-type-checking. Agh.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue May 17, 2022
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Member

Sorry about that @FloEdelmann (and any other user coming across this)! v5.25.0 should fix your issues with the strict ruleset.

Please do comment back if the same error occurs for you on >=5.25.0, or post a new issue for anything else!

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue May 17, 2022
Closed
4 tasks
@FloEdelmann
Copy link
Contributor Author

Seems to work fine now, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(eslint-plugin): strict config should not extend recommended JoshuaKGoldberg/typescript-eslint
2 participants
@FloEdelmann @JoshuaKGoldberg