Thanks for the PR, @uniqueiniquity!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Codecov Report

Merging #3484 (8892427) into master (dac8845) will decrease coverage by 0.02%.
The diff coverage is 86.66%.

❗ Current head 8892427 differs from pull request most recent head ae03746. Consider uploading reports for the commit ae03746 to get more accurate results

@@            Coverage Diff             @@
##           master    #3484      +/-   ##
==========================================
- Coverage   92.65%   92.63%   -0.03%     
==========================================
  Files         324      325       +1     
  Lines       11191    11226      +35     
  Branches     3158     3163       +5     
==========================================
+ Hits        10369    10399      +30     
- Misses        365      367       +2     
- Partials      457      460       +3     

Flags with carried forward coverage won't be shown. Click here to find out more.

On a real-world codebase with 30,000+ files, this reduced the linting time from ~60 minutes to ~10 minutes

Wow. Really?
So that's probably the biggest cause of slowness in our parser then.
That pretty much seals the deal on me wanting to add a environment variable to make this available to anyone without the need for custom scripts.

I never even knew that the watch program was so darn slow!

@bradzacher Really really. I need to get another clean run to truly verify, since the 7 minute run I had earlier had some issues with some of the TSLint rules being used via eslint-plugin-tslint (caused by resolving two different versions of typescript). But yeah, I think there's a ~100ms cost per-file involved with retrieving the program instance from the watch program, which really builds up over a project of this scale. I'm not really sure what causes that cost, though.

@bradzacher - After fixing the eslint-plugin-tslint issue, a run took 15 minutes, 6.5 of which were spent creating the program instance. So not quite as the earlier run, but still compellingly better.

Thank you so much!!