fix(eslint-plugin): [member-delimiter-style] correct invalid fix for multiline with params on the same line #3177
Conversation
|
Thanks for the PR, @tanohzana! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
tanohzana
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3177 +/- ##
==========================================
- Coverage 92.91% 92.91% -0.01%
==========================================
Files 316 316
Lines 10818 10829 +11
Branches 3059 3062 +3
==========================================
+ Hits 10052 10062 +10
Misses 342 342
- Partials 424 425 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| import { | ||
| RuleFix, | ||
| RuleFixer, | ||
| } from '@typescript-eslint/experimental-utils/src/ts-eslint'; |
There was a problem hiding this comment.
don't add deep imports on /src from plugins.
This is availaible on the TSESLint export of @typescript-eslint/experimental-utils
There was a problem hiding this comment.
Fixed here: a27e2e3
| multilineDetection: { | ||
| enum: ['brackets', 'last-member'], | ||
| }, |
There was a problem hiding this comment.
why have you removed this from the schema entirely?
There was a problem hiding this comment.
Fixed here: 75e83de
| @@ -21,14 +28,26 @@ type Config = BaseOptions & { | |||
| typeLiteral?: BaseOptions; | |||
| interface?: BaseOptions; | |||
| }; | |||
| multilineDetection?: 'brackets' | 'last-member'; | |||
There was a problem hiding this comment.
why have you removed this option entirely?
There was a problem hiding this comment.
Fixed here: e5353a9
bradzacher
added
the
awaiting response
|
Sorry for the unneeded changes, I had differences between the version I cloned a few weeks ago and the new one. But all should be fixed now |
bradzacher
removed
the
awaiting response
bradzacher
changed the title
Everything was explained here: #2982
The rule would produce invalid code when trying to fix it.
Fixes #2982