Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [sort-type-union-intersection-members] add nullish group #2919

Merged
merged 1 commit into from
Jan 5, 2021
Merged

feat(eslint-plugin): [sort-type-union-intersection-members] add nullish group #2919

merged 1 commit into from
Jan 5, 2021

Conversation

jgeurts
Copy link
Contributor

@jgeurts jgeurts commented Jan 5, 2021 •
edited
Loading

This adds a group called nullish to allow sorting null and undefined independently of the other types in the keywords group. Closes #2918

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @jgeurts!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jan 5, 2021 •
edited
Loading

Codecov Report

Merging #2919 (07e6393) into master (f606846) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2919   +/-   ##
=======================================
  Coverage   92.77%   92.78%           
=======================================
  Files         311      311           
  Lines       10456    10458    +2     
  Branches     2954     2954           
=======================================
+ Hits         9701     9703    +2     
  Misses        348      348           
  Partials      407      407
Flag Coverage Δ
unittest 92.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/rules/sort-type-union-intersection-members.ts 92.53% <100.00%> (+0.22%) ⬆️

@bradzacher bradzacher added the enhancement New feature or request label Jan 5, 2021
bradzacher
bradzacher requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please name this nullish instead?
nil isn't really a term used within JS.

Otherwise LGTM - thanks!

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jan 5, 2021
@jgeurts
feat(eslint-plugin): [sort-type-union-intersection-members] add nulli…
07e6393 
…sh group

This adds a group called nullish to allow sorting null and undefined independently of the other types in the keywords group. Closes #2918
@jgeurts jgeurts changed the title feat(eslint-plugin): [sort-type-union-intersection-members] add nil group feat(eslint-plugin): [sort-type-union-intersection-members] add nullish group Jan 5, 2021
bradzacher
bradzacher approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 5558f41 into typescript-eslint:master Jan 5, 2021
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 5, 2021
@jgeurts jgeurts deleted the sort-type-union-intersection-members-nil branch January 5, 2021 20:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sort-type-union-intersection-members] Can null and undefined be sorted separately from other keywords?
2 participants
@jgeurts @bradzacher