feat(eslint-plugin): [prom-func-async] report only function head #2872
Conversation
This reverts commit f568a9f.
|
Thanks for the PR, @phaux! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2872 +/- ##
=======================================
Coverage 92.87% 92.88%
=======================================
Files 314 315 +1
Lines 10670 10677 +7
Branches 3026 3028 +2
=======================================
+ Hits 9910 9917 +7
Misses 344 344
Partials 416 416
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| * ^^^^^^^^^ | ||
| * ``` | ||
| */ | ||
| export function getFunctionHeadLoc( |
There was a problem hiding this comment.
while we're here - one case I believe this code doesn't correctly handle is decorators because decorators are included within the method's start.
Eg this code will highlight:
class Foo {
@deco
^^^^^
foo() {}
^^^^^
}this has confused some people in the past (eg #751)
bradzacher
added
the
awaiting response
|
Sorry for not responding for so long. I had a break from open source. I will get to it on this weekend or maybe the next. |
|
Done! |
bradzacher
removed
the
awaiting response
Depends on #2845.
Changes report location to be only the function head without the whole body, like in explicit-module-boundary-types.