Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript-estree): use TSEmptyBodyFunctionExpression for body-less nodes #1289

Merged
merged 4 commits into from
May 10, 2020
Merged

fix(typescript-estree): use TSEmptyBodyFunctionExpression for body-less nodes #1289

merged 4 commits into from
May 10, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 30, 2019 •
edited by bradzacher
Loading

BREAKING CHANGE:

Fixes #734

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label Dec 1, 2019
@bradzacher bradzacher added this to the 3.0.0 milestone Dec 3, 2019
@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Dec 3, 2019
@bradzacher
Copy link
Member

This overall LGTM, but it is technically a breaking change for direct consumers of ts-estree (like prettier cc @thorn0).

I'm thinking we should probably look to doing a 3.0.0 release v soon, as the number of things is starting to reach a decent sized pile (see the milestone) cc @JamesHenry

@G-Rath
Copy link
Contributor Author

G-Rath commented Dec 4, 2019 •
edited by bradzacher
Loading

@bradzacher not entirely sure what I can do about the diff coverage, as it doesn't seem to like the fact that I force pushed, and removed so many lines from parser.

I can't find a nice chunk where I'm missing coverage that I can hit easily :/

@bradzacher
Copy link
Member

@G-Rath
https://codecov.io/gh/typescript-eslint/typescript-eslint/compare/b5a52a3aae85fce3bc45b39a2107a00d2655f5f9...732668047bfd2658fb3ad884a4732896974a973b/diff#D5-1140

Just one branch codecov doesn't think you've tested.

Also please be careful with your @ tagging. My username isn't the first "brad" username alphabetically, and github isn't smart enough to be contextually aware. (I've emailed them about it, but they are yet to fix it..)

@G-Rath
Copy link
Contributor Author

G-Rath commented Dec 5, 2019

@bradzacher Turns out that wasn't actually needed - Let me know if there's any other changes you'd like made for this 😄

Also cheers for pointing out the wrong tagging 😬

@codecov
Copy link

codecov bot commented Jan 12, 2020 •
edited
Loading

Codecov Report

Merging #1289 into v3 will decrease coverage by 0.03%.
The diff coverage is 87.17%.

@@            Coverage Diff             @@
##               v3    #1289      +/-   ##
==========================================
- Coverage   93.91%   93.87%   -0.04%     
==========================================
  Files         171      172       +1     
  Lines        7787     7805      +18     
  Branches     2238     2240       +2     
==========================================
+ Hits         7313     7327      +14     
- Misses        217      221       +4     
  Partials      257      257
Flag Coverage Δ
#unittest 93.87% <87.17%> (-0.04%) ⬇️
Impacted Files Coverage Δ
...xperimental-utils/src/eslint-utils/applyDefault.ts 100.00% <ø> (ø)
.../experimental-utils/src/ts-eslint-scope/analyze.ts 100.00% <ø> (ø)
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts 80.17% <50.00%> (+0.17%) ⬆️
packages/eslint-plugin/src/util/objectIterators.ts 66.66% <66.66%> (ø)
packages/eslint-plugin/src/rules/ban-types.ts 100.00% <100.00%> (ø)
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.40% <100.00%> (ø)
...ackages/eslint-plugin/src/rules/member-ordering.ts 98.46% <100.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts 99.15% <100.00%> (ø)
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts 100.00% <100.00%> (ø)
packages/typescript-estree/src/convert.ts 99.15% <100.00%> (+<0.01%) ⬆️
... and 2 more

@bradzacher bradzacher changed the base branch from master to v3 May 9, 2020 23:41
@bradzacher bradzacher changed the title fix(ts-estree): use TSEmptyBodyFunctionExpression for body-less nodes fix(typescript-estree): use TSEmptyBodyFunctionExpression for body-less nodes May 9, 2020
@bradzacher bradzacher merged commit 9493d13 into typescript-eslint:v3 May 10, 2020
bradzacher pushed a commit that referenced this pull request May 11, 2020
@G-Rath @bradzacher
fix(typescript-estree): use TSEmptyBodyFunctionExpression for body-…
fcd3076 
…less nodes (#1289)
bradzacher pushed a commit that referenced this pull request May 14, 2020
@G-Rath @bradzacher
fix(typescript-estree): use TSEmptyBodyFunctionExpression for body-…
3e70fb2 
…less nodes (#1289)
bradzacher pushed a commit that referenced this pull request May 17, 2020
@G-Rath @bradzacher
fix(typescript-estree): use TSEmptyBodyFunctionExpression for body-…
dbbc984 
…less nodes (#1289)
bradzacher pushed a commit that referenced this pull request May 21, 2020
@G-Rath @bradzacher
fix(typescript-estree): use TSEmptyBodyFunctionExpression for body-…
82e7163 
…less nodes (#1289)
@fisker fisker mentioned this pull request May 26, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

@thorn0 thorn0 thorn0 left review comments

Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

When can body be undefined or null in vanilla espree?
3 participants
@G-Rath @bradzacher @thorn0