feat(eslint-plugin): Migrate plugin to ts #120

bradzacher · 2019-01-22T05:51:54Z

Migrates eslint-plugin to typescript.
There's a big refactor in here to make creating a rule easier / more standardised.

Types are a lot stricter:
- Rule meta must use messageId.
- Rule meta must include docs.
  - Docs must include category, description, and recommended.
Reduced boilerplate:
- Automatically adds url to the meta.
- Automatically merges default options for a rule
- Once Implement partial type argument inference using the _ sigil microsoft/TypeScript#26349 is merged, the generic typing will only require the TOptions type.
  - Maybe we can look at auto-generating the JSONSchema in future based on the interface type?

Build is passing across the board.

Note that the packages will now include .js.map and .d.ts.map files.

Tests have been largely untouched apart from the rename, and they are all passing.

closes #47
closes #40

Waiting for the following PRs to be merged in to master:
#178, #192, #204, #215, #231

Closed waiting PRs
~~#155, #194, #199, #206, #222, #226, #232~~

packages/eslint-plugin/src/lib/rules/type-annotation-spacing.ts

packages/eslint-plugin/.npmignore

packages/eslint-plugin/src/lib/rules/ban-types.ts

packages/eslint-plugin/src/lib/rules/member-naming.ts

packages/eslint-plugin/src/lib/util.ts

packages/eslint-plugin/tools/update-recommended.ts

packages/eslint-plugin/tsconfig.json

packages/eslint-plugin/typings/eslint-rules.d.ts

tsconfig.json

# Conflicts: # packages/eslint-plugin/lib/util.js # packages/eslint-plugin/src/lib/rules/no-object-literal-type-assertion.ts

…de) (#137)

# Conflicts: # packages/eslint-plugin/lib/rules/adjacent-overload-signatures.js # packages/eslint-plugin/lib/util.js # packages/eslint-plugin/package.json # packages/parser/src/eslint-scope.d.ts # packages/parser/src/parser.ts # packages/parser/src/typings.d.ts # packages/parser/typings/eslint-scope.d.ts # packages/typescript-estree/package.json # packages/typescript-estree/src/node-utils.ts # packages/typescript-estree/src/parser.ts

# Conflicts: # packages/eslint-plugin/lib/rules/no-unnecessary-type-assertion.js

… code)

armano2 · 2019-02-10T17:28:58Z

Can we split this PR to few smaller one and merge them one by one?

add typecheck for tests (new tsconfig.json configs)
add new types and export them to from parser
changes to rules and type definition for plugin

right now this PR is getting bigger and bigger and its really hard to review and check if there is no actual issues

armano2 · 2019-02-10T18:11:18Z

can you update analyze-scope.ts,

- TSEmptyBodyFunctionExpression(node: TSESTree.FunctionExpression): void
+ TSEmptyBodyFunctionExpression(node: TSESTree.TSEmptyBodyFunctionExpression): void

packages/eslint-plugin/tests/rules/no-array-constructor.test.ts

packages/eslint-plugin/tests/rules/no-extraneous-class.test.ts

packages/eslint-plugin/tests/rules/no-for-in-array.test.ts

packages/eslint-plugin/src/util/applyDefault.ts

packages/eslint-plugin/src/util/createRule.ts

packages/eslint-plugin/src/util/misc.ts

packages/eslint-plugin/tests/RuleTester.ts

bradzacher added 5 commits January 21, 2019 12:18

rename files and start migration

37dd878

start converting rules

c651723

first pass type conversion done

1714d3b

es6 exports

bcb3288

correct tooling paths

5e68332

bradzacher added the DO NOT MERGE PRs which should not be merged yet label Jan 22, 2019

bradzacher self-assigned this Jan 22, 2019

fix update-recommended script

bbc841a

armano2 reviewed Jan 22, 2019

View reviewed changes

packages/eslint-plugin/src/lib/rules/type-annotation-spacing.ts Outdated Show resolved Hide resolved

armano2 reviewed Jan 22, 2019

View reviewed changes

packages/eslint-plugin/.npmignore Outdated Show resolved Hide resolved

add missing manual module typing files

0d3e8ff