fix(parser): fix regression with no-unused-vars for jsx attributes (#161

)
typescript-eslint · Jan 29, 2019 · 6147de1 · 6147de1
1 parent 38abc28
commit 6147de1
Show file tree

Hide file tree

Showing 4 changed files with 483 additions and 2 deletions.
diff --git a/packages/eslint-plugin/tests/lib/rules/no-unused-vars.js b/packages/eslint-plugin/tests/lib/rules/no-unused-vars.js
@@ -558,8 +558,8 @@ import foo from 'foo';
 import bar from 'foo';
 export interface Bar extends foo.i18n<bar> {}
     `,
-    // https://github.com/typescript-eslint/typescript-eslint/issues/141
     {
+      // https://github.com/typescript-eslint/typescript-eslint/issues/141
       filename: 'test.tsx',
       code: `
 import { TypeA } from './interface';
@@ -570,6 +570,20 @@ export const a = <GenericComponent<TypeA> />;
           jsx: true
         }
       }
+    },
+    {
+      // https://github.com/typescript-eslint/typescript-eslint/issues/160
+      filename: 'test.tsx',
+      code: `
+const text = 'text';
+export function Foo() {
+  return (
+    <div>
+      <input type="search" size={30} placeholder={text} />
+    </div>
+  );
+}
+      `
     }
   ],
 

diff --git a/packages/parser/src/analyze-scope.ts b/packages/parser/src/analyze-scope.ts
@@ -241,7 +241,7 @@ class Referencer extends OriginalReferencer {
   JSXOpeningElement(node: any) {
     this.visit(node.name);
     this.visitTypeParameters(node);
-    this.visit(node.attributes);
+    node.attributes.forEach(this.visit, this);
   }
 
   /**

diff --git a/packages/parser/tests/fixtures/scope-analysis/jsx-attributes.tsx b/packages/parser/tests/fixtures/scope-analysis/jsx-attributes.tsx
@@ -0,0 +1,8 @@
+const text = 'text';
+export function Foo() {
+  return (
+    <div>
+      <input type="search" size={30} placeholder={text} />
+    </div>
+  );
+}