Fix C# README examples and add issues refs to recent TODOs #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farost
commented
Apr 22, 2024
| @@ -57,7 +57,7 @@ class TestRunner : public TestRunnerBase { | |||
| steps.reserve(totalSteps); | |||
| for (const StepCollection<CTX> stepVec : stepLists) { | |||
| for (const cucumber_bdd::StepDefinition<CTX> stepDef : stepVec) { | |||
| steps.push_back(StepDefinition<CTX>{stepDef.regex, stepDef.impl}); // TODO: Avoid deep copy? | |||
| steps.push_back(StepDefinition<CTX>{stepDef.regex, stepDef.impl}); | |||
There was a problem hiding this comment.
Doesn't look like we will be interested in fixing it in the future. @krishnangovindraj approved this TODO's removal.
farost
commented
Apr 22, 2024
| @@ -293,7 +293,7 @@ build: | |||
|
|
|||
| source tool/test/start-cloud-servers.sh 3 && # use source to receive export vars | |||
| bazel test //python/tests/integration:test_connection --test_env=ROOT_CA=$ROOT_CA --test_output=streamed --jobs=1 && | |||
| # TODO currently broken test | |||
| # TODO #635: currently broken test | |||
There was a problem hiding this comment.
This format comes from the short links format, but we can switch to full URLs if it's not that comfortable. I'm open to discussions.
flyingsilverfin
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage and product changes
C# driver's examples should be able to be built in any namespace now.
Some of the recent
TODOs left in the codebase have been cleaned or marked with a specific GitHub issue number.Implementation
We suggest leaving refs to GitHub's issues for each newly merged
TODOs not to lose track of these problems and have more context behind them. It can be done:#issuenumberif the issue is a part of the target repo;