[#9093] A few more h2.errors instances in twisted #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As ticket 9092 is fixed, you'll need to open a new one I'm afraid. :( |
alexwlchan
changed the title
Whaaaaaaaat. Such effort. Much hard. Anyway, done.
This time I’ve grepped the entire codebase for "h2.errors" and "h2.settings", rather than just going on the Travis output. I don’t see anywhere else that needs to change. |
|
Heh, that seems like the best long-term approach. 😁 |
Lukasa
approved these changes
Mar 23, 2017
Codecov Report
@@ Coverage Diff @@
## trunk #752 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 844 844
Lines 147595 147595
Branches 13060 13060
=======================================
Hits 134713 134713
Misses 10639 10639
Partials 2243 2243Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/me gnashes teeth
Okay, I think this is the final bit. Over to @Lukasa for review. Related to #751.
https://twistedmatrix.com/trac/ticket/9093