Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10251: Fix IReactorTCP.connectTCP type parameter type #1664

Merged
merged 2 commits into from
Sep 19, 2021
Merged

10251: Fix IReactorTCP.connectTCP type parameter type #1664

merged 2 commits into from
Sep 19, 2021

Conversation

twm
Copy link
Contributor

@twm twm commented Sep 19, 2021

Correct the type annotation to match real-world implementations as discussed on the mailing list.

Contributor Checklist:

  • The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/10251
  • I ran tox -e lint to format my patch to meet the Twisted Coding Standard
  • I have created a newsfragment in src/twisted/newsfragments/ (see: News files)
  • The title of the PR starts with the associated Trac ticket number (without the # character).
  • I have updated the automated tests and checked that all checks for the PR are green. (N/A)
  • I have submitted the associated Trac ticket for review by adding the word review to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.
  • The merge commit will use the below format
    The first line is automatically generated by GitHub based on PR ID and branch name.
    The other lines generated by GitHub should be replaced.
Merge pull request #123 from twisted/4356-branch-name-with-trac-id

Author: twm
Reviewer: <github_username>, <github_username_if_more_reviewers>
Fixes: ticket:10251

Correct the IReactorTCP.connectTCP host parameter type annotation to match
real-world implementations as discussed on the mailing list.

@twm twm requested a review from a team September 19, 2021 02:02
adiroiban
adiroiban approved these changes Sep 19, 2021
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks!

@twm twm merged commit ec7445d into trunk Sep 19, 2021
@twm
Copy link
Contributor Author

twm commented Sep 19, 2021

Thank you for the review, @adiroiban!

@twm twm deleted the 10251-connecttcp-host-type branch September 19, 2021 20:10
@clokep clokep mentioned this pull request Sep 20, 2021
Closed
DMRobertson pushed a commit to matrix-org/synapse that referenced this pull request Sep 23, 2021
Pass str to twisted's IReactorTCP
b87e1b6 
This follows a correction made in twisted/twisted#1664.

Until that change is in a twisted release, we'll have to ignore the type
of the `host` argument. I'll raise an issue to remind us to review the
issue in a few months' time.
@DMRobertson DMRobertson mentioned this pull request Sep 23, 2021
Merged
DMRobertson pushed a commit to matrix-org/synapse that referenced this pull request Sep 30, 2021
Pass str to twisted's IReactorTCP (#10895)
2936414 
This follows a correction made in twisted/twisted#1664 and should fix our Twisted Trial CI job.

Until that change is in a twisted release, we'll have to ignore the type
of the `host` argument. I've raised #10899 to remind us to review the
issue in a few months' time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twm @adiroiban