Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10250 update CI and trove to 3.10 #1659

Merged
merged 10 commits into from
Sep 6, 2021
Merged

10250 update CI and trove to 3.10 #1659

merged 10 commits into from
Sep 6, 2021

Conversation

graingert
Copy link
Member

Scope and purpose

Twisted 21.7.0 announced tentative support for python 3.10 because only a beta was available to test against. This PR represents no actual source changes, and only downstream tooling changes (twisted-iocpsupport and cython-test-exception-raiser) both upgraded to cibuildwheel 2 for 3.10 wheels.

Contributor Checklist:

  • The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/10250
  • I ran tox -e lint to format my patch to meet the Twisted Coding Standard
  • I have created a newsfragment in src/twisted/newsfragments/ (see: News files)
  • The title of the PR starts with the associated Trac ticket number (without the # character).
  • I have updated the automated tests and checked that all checks for the PR are green.
  • I have submitted the associated Trac ticket for review by adding the word review to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.
  • The merge commit will use the below format
    The first line is automatically generated by GitHub based on PR ID and branch name.
    The other lines generated by GitHub should be replaced.
Merge pull request #123 from twisted/4356-branch-name-with-trac-id

Author: <github_username>, <github_usernames_if_more_authors>
Reviewer: <github_username>, <github_username_if_more_reviewers>
Fixes: ticket:<trac_ticket_number>, ticket:<another_if_more_in_one_PR>

Long description providing a summary of these changes.
(as long as you wish)

@graingert
Copy link
Member Author

this is a draft until it's tested with a twisted-iocpsupport 3.10 wheel

@graingert
Copy link
Member Author

this is the cause of the sphinx failure: sphinx-doc/sphinx#9505

adiroiban
adiroiban reviewed Aug 10, 2021
View reviewed changes
.github/workflows/test.yaml
@@ -32,7 +32,7 @@ jobs:
# When updating the minimum Python version here, also update the
# `python_requires` from `setup.cfg`.
# Run on latest minor release of each major python version.
python-version: [3.6, 3.7, 3.8, 3.9, 3.10rc1]
python-version: [3.6, 3.7, 3.8, 3.9, 3.10.0-rc.1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just set 3.10 and have it automatically updated just like the other version? Just asking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@altendky made the trio python-version auto pick the latest Python build, but I think it would be better to update it dependabot style

@graingert
Copy link
Member Author

@adiroiban release announcement for twisted-iocpsupport here:

https://mail.python.org/archives/list/twisted@python.org/thread/UJDLXLQUNFRIKHP7B2J2WH3DK43S7GAI/

@graingert graingert requested a review from adiroiban August 23, 2021 12:33
graingert
graingert commented Sep 6, 2021
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
@graingert graingert marked this pull request as ready for review September 6, 2021 14:32
adiroiban
adiroiban approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good. thanks.

I guess that we can update the sphinx deps we have an upstream fix...

but do we run sphinx on python 3.10?

Thanks!

@graingert
Copy link
Member Author

all good. thanks.

I guess that we can update the sphinx deps we have an upstream fix...

but do we run sphinx on python 3.10?

yep - the tests run sphinx, but the readthedocs.org bot is still stuck on 3.8 which is on security fixes only

Thanks!

@graingert graingert closed this Sep 6, 2021
@graingert graingert reopened this Sep 6, 2021
@graingert graingert enabled auto-merge September 6, 2021 16:03
@graingert graingert merged commit 6d34a9f into twisted:trunk Sep 6, 2021
@graingert graingert deleted the 310rc1 branch September 6, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graingert @adiroiban