10177: Sessions: use the site reactor, not the global one #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose the reactor associated with the `Site` by renaming the `_reactor` attribute to `reactor` in its superclass `HTTPFactory`. Make the `Session` initializer take the reactor from its *site* argument when the explicit *reactor* argument isn't passed. It used to use the global reactor. There were a few tests that called the `Session` constructor with incorrect arguments. It looks like the `uid` used to be an integer, but it's bytes now. Also a few had the *uid* and *site* arguments swapped. I also added some missing documentation.
|
Thank you for the review @wsanchez! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the reactor associated with the
Siteby renaming the_reactorattribute toreactorin its superclassHTTPFactory. Consider this pursuant to #3205.Make the
Sessioninitializer take the reactor from its site argument when the explicit reactor argument isn't passed. It used to use the global reactor.There were a few tests that called the
Sessionconstructor with incorrect arguments. It looks like theuidused to be an integer, but it's bytes now. Also, a few had the uid and site arguments swapped.I also added some missing documentation.
See twisted/treq#327 and twisted/treq#328 for background.
Contributor Checklist:
tox -e lintto format my patch to meet the Twisted Coding Standard#character).reviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.