10146 type annotate twisted.application.reactors and twisted.application.strports #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
changed the title
graingert
commented
Mar 19, 2021
graingert
changed the title
graingert
changed the title
graingert
force-pushed
the
type-annotated-twisted-application-reactors
branch
from
13e4925 to
ab85301
Compare
ModuleNotFoundError: No module named 'twisted.interfaces'You want |
graingert
force-pushed
the
type-annotated-twisted-application-reactors
branch
from
ab85301 to
5c38f85
Compare
wsanchez
reviewed
Mar 20, 2021
| @@ -53,23 +54,23 @@ class Reactor: | |||
| the install callable is an attribute. | |||
| """ | |||
|
|
|||
| def __init__(self, shortName, moduleName, description): | |||
| def __init__(self, shortName: str, moduleName: str, description: str): | |||
There was a problem hiding this comment.
Shouldn't this have -> None?
There was a problem hiding this comment.
nope, __init__ gains them by default
wsanchez
reviewed
Mar 20, 2021
Comment on lines
+17
to
+20
| def _getReactor() -> interfaces.IReactorCore: | ||
| from twisted.internet import reactor | ||
|
|
||
| return cast(interfaces.IReactorCore, reactor) |
There was a problem hiding this comment.
I'm pretty sure we're going to need to add a public getInstalledReactor() callable like this, because of this casting requirement, so clients don't have to add this in every project.
wsanchez
reviewed
Mar 20, 2021
| @@ -198,7 +211,7 @@ def getPlugins(interface, package=None): | |||
| @return: An iterator of plugins. | |||
| """ | |||
| if package is None: | |||
| import twisted.plugins as package | |||
| package = _pluginsPackage() | |||
There was a problem hiding this comment.
I'm curious what this change does
There was a problem hiding this comment.
It works around the redefinition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
because they are the smallest modules
Contributor Checklist:
tox -e lintto format my patch to meet the Twisted Coding Standard#character).reviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.twisted/twisted-contributorsteams to the PRReviewers.The first line is automatically generated by GitHub based on PR ID and branch name.
The other lines generated by GitHub should be replaced.