Fix some of the Twisted web examples on Python 3 #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files are not standalone Python files.
twm
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
This looks good! I think that there is still a type error with static.Data that should be addressed before merge. Additionally, please uncomment this line:
Line 46 in e1c54d7
Thanks!
| (request.write(s+"\n"), request.finish())) | ||
| deferred.addErrback(lambda s: | ||
| (request.write(str(s)), request.finish())) | ||
| deferred.addCallback(lambda s: (request.write(s + b"\n"), request.finish())) |
There was a problem hiding this comment.
Man, this is a gross hack. Not that you should fix it now, I just couldn't let it pass.
rodrigc
force-pushed
the
9959-rodrigc-twisted-web-py3
branch
from
60eb182 to
605d765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist:
reviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.