Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9931] defer reactor import in twisted.web.xmlrpc #1370

Merged
merged 1 commit into from
Sep 17, 2020
Merged

[9931] defer reactor import in twisted.web.xmlrpc #1370

merged 1 commit into from
Sep 17, 2020

Conversation

graingert
Copy link
Member

@graingert graingert commented Aug 4, 2020 •
edited by wsanchez
Loading

Remove this section

Please have a look at our developer documentation before submitting your Pull Request.

Please note that the trac ticket, news fragment, and review submission portions of this process apply to all pull requests, no matter how small; if you don't do them, it's likely that nobody will even notice your PR needs a review.

Contributor Checklist:

@graingert graingert requested a review from wsanchez August 27, 2020 22:50
@twm twm changed the title defer reactor import in twisted.web.xmlrpc [9931] defer reactor import in twisted.web.xmlrpc Sep 14, 2020
@wsanchez
Copy link
Member

@graingert Look like there's a linter error that needs fixing prior to merge.

@graingert
Copy link
Member Author

@wsanchez fixed the lint error

@twm twm merged commit 8d38a34 into twisted:trunk Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsanchez wsanchez wsanchez approved these changes

Assignees
No one assigned
Labels
needs-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graingert @wsanchez @twm