#11834 Use reversed instead of creating a copy of slotData for every call to _getSlotValue #11833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… _getSlotValue This takes a large sphinx build with pydoctor from a 22 minute runtime to a 15 min runtime.
dreid
changed the title
|
I do not understand the pypy failures. It seems unrelated but also it seems to fail consistently. I'm I couldn't find any other examples of similar failures on outstanding PRs but I only checked 3 or 4. |
exarkun
reviewed
Mar 28, 2023
The most recent trunk run has exactly these failures. |
exarkun
approved these changes
Mar 28, 2023
Co-authored-by: Jean-Paul Calderone <exarkun@twistedmatrix.com>
|
@exarkun Thank you for the review, bummer about the speedscope link. I've updated the news fragment. I do not have permissions to merge PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #11834
Contributor Checklist:
This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.
Below is a non-exhaustive list (as a reminder):
please review.Our bot will trigger the review process, by applying the pending review label
and requesting a review from the Twisted dev team.