Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in docs/core/howto/trial.rst #1175

Merged
merged 3 commits into from
Oct 18, 2019
Merged

Conversation

Gallaecio
Copy link
Contributor

@Gallaecio Gallaecio commented Aug 4, 2019

Contributor Checklist:

  • The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/9690
  • I have created a newsfragment in src/twisted/newsfragments/
  • I have submitted the associated Trac ticket for review by adding the word review to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.

@Gallaecio
Copy link
Contributor Author

I’m hoping such a minor documentation fix does not require to follow the whole process described at https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch. Otherwise, please let me know.

@glyph
Copy link
Member

glyph commented Aug 5, 2019

@Gallaecio It does - or at least the parts that are relevant. You don't have to make test changes or lint changes if you didn't add code :).

You happen to have submitted the same day that I do my once-every-six-months scan of the PR list, but generally Twisted maintainers check https://twisted.reviews/ to see what needs doing (Github does not have the ability for submitters add labels, or request reviews, so tracking the state that Trac currently does for us requires a bot, which nobody has yet set up.)

@glyph glyph merged commit d0585e7 into twisted:trunk Oct 18, 2019
@glyph
Copy link
Member

glyph commented Oct 18, 2019

Thanks for your contribution to Twisted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants