9176 redux #1031
Merged
9176 redux #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
twisted.internet.test.test_inlinecb
ForwardTraceBackTests
test_forwardLotsOfTracebacks ... Traceback (most recent call last):
File "twisted/src/twisted/internet/defer.py", line 1532, in unwindGenerator
return _inlineCallbacks(None, gen, Deferred())
File "twisted/src/twisted/internet/defer.py", line 1386, in _inlineCallbacks
result = g.send(result)
File "twisted/src/twisted/internet/test/test_inlinecb.py", line 162, in calling3
yield erroring()
File "twisted/src/twisted/internet/defer.py", line 1532, in unwindGenerator
return _inlineCallbacks(None, gen, Deferred())
--- <exception caught here> ---
File "twisted/src/twisted/internet/defer.py", line 1386, in _inlineCallbacks
result = g.send(result)
File "twisted/src/twisted/internet/test/test_inlinecb.py", line 157, in erroring
raise Exception()
builtins.Exception:
After:
twisted.internet.test.test_inlinecb
ForwardTraceBackTests
test_forwardLotsOfTracebacks ... Traceback (most recent call last):
File "twisted/src/twisted/internet/defer.py", line 1532, in unwindGenerator
return _inlineCallbacks(None, gen, Deferred())
File "twisted/src/twisted/internet/defer.py", line 1386, in _inlineCallbacks
result = g.send(result)
File "twisted/src/twisted/internet/test/test_inlinecb.py", line 162, in calling3
yield erroring()
File "twisted/src/twisted/internet/defer.py", line 1532, in unwindGenerator
return _inlineCallbacks(None, gen, Deferred())
--- <exception caught here> ---
File "twisted/src/twisted/internet/test/test_inlinecb.py", line 170, in calling
yield calling2()
File "twisted/src/twisted/internet/test/test_inlinecb.py", line 166, in calling2
yield calling3()
File "twisted/src/twisted/internet/test/test_inlinecb.py", line 162, in calling3
yield erroring()
File "twisted/src/twisted/internet/defer.py", line 1386, in _inlineCallbacks
result = g.send(result)
File "twisted/src/twisted/internet/test/test_inlinecb.py", line 157, in erroring
raise Exception()
builtins.Exception:
Actually, that unit test demonstrated an issue with the fact that original failure was changed by the failure chaining code.
"The new Failure should be chained to that original Failure." Should it be the exact same Failure? or should it also include were the Failure was rethrown?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #814 just for the purposes of merging. (It should auto-close when this lands.)