[security] Don't generate 1024-bit RSA keys #1015
Conversation
alex
changed the title
|
Test failures are due to the bug being fixed in #1014 |
Codecov Report
@@ Coverage Diff @@
## trunk #1015 +/- ##
========================================
Coverage ? 89.67%
========================================
Files ? 844
Lines ? 150896
Branches ? 13160
========================================
Hits ? 135313
Misses ? 13257
Partials ? 2326 |
| @@ -0,0 +1 @@ | |||
| twisted.internet._sslverify.KeyPair.generate: No longer generate 1024-bit RSA keys by default. Anyone who generated a key with this method using the default value should move to replace it immediately. | |||
There was a problem hiding this comment.
The public name of the API is twisted.internet.ssl.KeyPair.
There was a problem hiding this comment.
Also the style guideline for news fragments suggests this should be more like:
twisted.internet.ssl.KeyPair.generate now defaults to generating a 2048 bit key.
I doubt that this is an effective place to provide "immediate" security action guidance.
|
@markrwilliams do you need anything from me on this? |
|
@alex Sorry for my terse message. You don't need to do anything more - this only needs successful builds from Appveyor and Travis, both of which failed for unrelated reasons: https://ci.appveyor.com/project/adiroiban/twisted/build/trunk-5076/job/kh8d8chxucxo3ni8#L18437 |
|
@markrwilliams thanks! they look to be green now. |
|
|
Contributor Checklist: