-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors while writing dropin.cache should show a less horrible error message #2644
Comments
Surely you mean |
I'm not sure it's an improvement to make a system misconfiguration less visible. In any case, the message should not start with warning. The rest of the example sentence conveys just as much information without the prefix. |
I do believe that the most common error - that the dropin.cache file cannot be opened for writing - should be caught and logged as a warning rather than an error. I'll file a separate ticket for that. |
(by "logged as a warning" I mean "warnings.warn", not log.err("something misleading")). |
Replying to glyph:
Does such a ticket exist yet? I can't find it. But actually, that particular case is all I was referring to when I made this ticket, so I don't think a separate ticket needs to be filed. |
Replying to radix:
I believe #2409 is the ticket in question. Is this a duplicate now? |
Yes. Thanks for finding that. |
I suggest doing something like
log.err("warning: Couldn't write dropin.cache file because %s" % (e,))
instead of log.err()
Searchable metadata
The text was updated successfully, but these errors were encountered: