Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.plugin caching and read-only package directories #11236

Closed
twisted-trac opened this issue Apr 22, 2005 · 12 comments
Closed

t.plugin caching and read-only package directories #11236

twisted-trac opened this issue Apr 22, 2005 · 12 comments

Comments

@twisted-trac
Copy link

mg's avatar mg reported
Trac ID trac#996
Type enhancement
Created 2005-04-22 02:32:25Z
Searchable metadata
trac-id__996 996
type__enhancement enhancement
reporter__mg mg
priority__normal normal
milestone__ 
branch__ 
branch_author__ 
status__closed closed
resolution__invalid invalid
component__core core
keywords__ 
time__1114137145000000 1114137145000000
changetime__1234148755000000 1234148755000000
version__ 
owner__ 
cc__moonfallen cc__radix cc__exarkun cc__symbiont cc__mg
@twisted-trac
Copy link
Author

mg's avatar mg commented
#!html
<pre>
t.plugin writes the dropin.cache to the package's directory. However, it's not
uncommon for that directory to be read only, i.e. when Twisted is installed to
site-packages but all the Twisted apps run as a non-root user. Perhaps t.plugin
should cache in memory instead or as well writing to the package dir?
</pre>

@twisted-trac
Copy link
Author

exarkun's avatar @exarkun commented
#!html
<pre>
It is intended that the install process write the cache files.
</pre>

@twisted-trac
Copy link
Author

moonfallen's avatar moonfallen commented
#!html
<pre>
Would someone explain how this works?
</pre>

@twisted-trac
Copy link
Author

mg's avatar mg commented
#!html
<pre>
Searching for any type of plugin in a package is enough to write the
dropin.cache to the package directory. It should be enough to load up Twisted's
IServiceMaker plugins once Twisted has been installed.

I'm not sure of the correct way to load IServiceMaker plugins but
twisted.scripts.mktap.loadPlugins() looks like a reasonable choice. However:

  * Are there any other Twisted plugin types that need loading at
    installation time that moonfallen and radix should know about?
  * What about other packages/applications that provide/use plugins? Should
    they be catered for better?
</pre>

@twisted-trac
Copy link
Author

moonfallen's avatar moonfallen commented
#!html
<pre>
Committed r13679.
</pre>

@twisted-trac
Copy link
Author

exarkun's avatar @exarkun commented
#!html
<pre>
Yay Windows.

Anyone feel like getting the other installers (bare setup.py, .dpkg, .rpm?) to
do this, too?
</pre>

@twisted-trac
Copy link
Author

mg's avatar mg commented
#!html
<pre>
Cross referencing to issue 1126 "Packge Twisted using Eggs/EasyInstall" because
they probably affect each other.
</pre>

@twisted-trac
Copy link
Author

exarkun's avatar @exarkun set owner to @radix

This seems release related, basically. I might do some work on this, but someone should clarify what the remaining work to be done is.

@twisted-trac
Copy link
Author

zooko's avatar @zooko commented

#2406 is a ticket about how to handle the warnings that result when this directory isn't writable when we're attempting to update the cache file.

By the way, this is a headache for me because setuptools/easy_install don't have a method of executing arbitrary code after install -- post-install hooks. So I'm kind of hoping that this somehow goes away. Maybe mg's suggestion of using RAM for the cache should be reconsidered -- it would go a lot faster in some cases...

@twisted-trac
Copy link
Author

glyph's avatar @glyph commented

Zooko meant #2409.

@twisted-trac
Copy link
Author

glyph's avatar @glyph set status to closed

OK, so, after thinking about this a bit, this ticket doesn't really describe any course of action, just notes a potential issue. I think that #2409 is a much more useful ticket related to that issue, so I'm going to close this one as invalid since I have no idea how this is actionable any more.

@twisted-trac
Copy link
Author

Automation's avatar Automation removed owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant