Make <Background /> component responsive #4767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this first PR! Going with a JS-first approach for CSS issues is usually a last-resort, it can be avoid in most cases and probably here too. JS is harder to maintain and often leads to edge-cases as it does here: 
Had you tried something with ::before and ::after selector? |
|
@FelixMalfait I partly implemented your suggestions, and it should be working much better now :) |
FelixMalfait
approved these changes
Apr 12, 2024
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
- Adjusted the height of the background image to fit every possible screen - Added the proper rotation degree to the background - Refactored gradient colour stop into CONST to make sure each background image starts at the same level **To be noted :** I had to use Javascript and useEffect to make the div take the entire height of the page (turn it into a "use client" component). This was necessary because absolute positioning by default makes the element's sizing relative to its nearest positioned ancestor, not the entire document. --------- Co-authored-by: Ady Beraud <a.beraud96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be noted :
I had to use Javascript and useEffect to make the div take the entire height of the page (turn it into a "use client" component). This was necessary because absolute positioning by default makes the element's sizing relative to its nearest positioned ancestor, not the entire document.