Update twenty-front commands
#4667
Conversation
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
pacyL2K19
changed the title
twenty-front dev commandstwenty-front commands
|
@pacyL2K19 sorry for the slow review and thanks for your contribution! either @thaisguigon or I will take a look tomorrow! |
thaisguigon
force-pushed
the
chore/move-dev-commands
branch
11 times, most recently
from
fc9f182 to
f3d3937
Compare
thaisguigon
force-pushed
the
chore/move-dev-commands
branch
from
73151f7 to
4fb384a
Compare
There was a problem hiding this comment.
Hi @pacyL2K19!
As you can see, I have pushed commits to rework the commands so we can leverage Nx's native executors. I also fixed several things that were breaking in the CI after changing the config.
Overall great job, thank you for your contribution!
Thank you so much @thaisguigon |
# This PR - Moves dev and ci scripts to the `project.json` file in the twenty-front package - Adds a project.json file in the root of the project with the main start command that start both twenty-server and twenty-front applications concurrently - Updates the script command of the root project with the start:prod command (replacing the start command which will be used in dev with the help of nx) - Add a start:prod command in the twenty-front app, replacing the start command (now used for dev purpose) Issue ref twentyhq#4645 @charlesBochet @FelixMalfait please let me know how can I improve it --------- Co-authored-by: Thaïs Guigon <guigon.thais@gmail.com>
This PR
project.jsonfile in the twenty-front packageIssue ref #4645
@charlesBochet @FelixMalfait please let me know how can I improve it