Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap items in board #3643

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Remap items in board #3643

merged 2 commits into from
Jan 26, 2024

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Jan 26, 2024

Context

We are refactoring the record board which has been hard coded in the codebase to display opportunities.

What

In this PR:

  • adding state select field type on opportunity standard object
  • Introducing states to store columns: columnIds, columnFamilyState, columnFamilySelector (to ease usage), isColumnFirstFamilyState, isColumnLastFamilyState. We are introducing these familyState to guarantee good performance. A column should be able to read its columnInformation but do not re-render when other columns are changed.
  • using this state to compute board columns based on select field options (the first we find for now)
  • Re-adding columnHeader, columnMenu components but only redirecting to Settings to edit Select options
image

Next steps:

  • Display them through basic cards
  • re-apply viewFields
  • pagination (performance)
  • action bar, context menu, selection

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment otherwise lgtm

const navigate = useNavigate();

const navigateToSelectSettings = useCallback(() => {
navigate(`/settings/objects/${objectNamePlural}`);
}, [navigate, objectNamePlural]);
navigate(`/settings/objects/${objectNameSingular}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? I think the URL is using plural form as of today, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right!

@charlesBochet charlesBochet merged commit 070900e into main Jan 26, 2024
13 checks passed
@charlesBochet charlesBochet deleted the record-board-cards branch January 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants