GH-3245 Change password from settings page #3538

i-am-chitti · 2024-01-18T13:50:04Z

Description

This PR adds password reset feature to change password from settings page. Here is the workflow -

On clicking "Change Password", a reset token is generated. This is done via emailPasswordResetLink mutation. It generates the token and store its hash in DB with an expiry. It sends back the confirmation to user.
It mails the user their plain token. If user tries to generate the token again within a certain time defined in constant PASSWORD_RESET_TOKEN_EXPIRES_IN, it will throw error. Also, this constant is optional. Its default is 5 minutes.
Once user opens the link present in the email, he will be directed to reset-password/:token path. Here a validation of token is carried out through validatePasswordResetToken query. If invalid, in case of non-logged in, redirected to sign in page else to index page.
Next, password reset form appears. He enters the new password. Updation is done via mutation updatePasswordViaResetToken. It validates the token again and then, new password. New password should be same as old. On success, it updates the password and sends the success confirmation.
Now, if user was logged in, he will be directed to sign in page. Else, he is logged in programatically and directed to sign in page.

Have a look at the attached Gdrive link where complete flow has been recorded.

Issue

Change password from settings #3245

Note

Migration has been already added to add the DB column for storing token and expiry.
There was some unknown error during graphql data generation. Hence, had to use skipValidation in codegen.cjs. This error is not related to mine changes. It started popping once I synced the main branch. Request you to kindly regenerate the graphql files before merging.

Screenshots

Screencast

https://drive.google.com/file/d/1y6q6ocakQa6sScMuPZQYdDeXGuuNyFyQ/view?usp=sharing

…t column on user entity

…WIP) resolver

github-actions · 2024-01-18T13:51:30Z

	Warnings
⚠️	Changes were made to package.json, but not to yarn.lock - Perhaps you need to run `yarn install`?
⚠️	Changes were made to the environment variables, but not to the documentation - Please review your changes and check if a change needs to be documented!

Generated by 🚫 dangerJS against 4f481df

martmull · 2024-01-22T15:55:02Z

@i-am-chitti merging main in your branch should fix the graphql:data:generate command also

packages/twenty-server/src/core/auth/emails/password-reset-link.email.tsx

packages/twenty-server/src/core/auth/emails/password-update-notify.email.tsx

i-am-chitti · 2024-01-23T12:29:49Z

Thanks @martmull for the review. I'll be pushing the updates soon.

i-am-chitti · 2024-01-23T21:47:41Z

@martmull, I've made the changes. You can have a re-review.

martmull

Hey @i-am-chitti, that's really good work. I have some minor changes regarding email css and code style. I don't want to be too touchy on that so don't hesitate to ask me to pass those changes! Also, I will ask @lucasbordeau to double check the front part. Then we will be able to merge 🎉. Really nice job again!

packages/twenty-emails/src/components/Link.tsx

packages/twenty-emails/src/emails/password-reset-link.email.tsx

packages/twenty-emails/src/emails/password-update-notify.email.tsx

packages/twenty-emails/tsup.index.tsx

packages/twenty-emails/src/emails/password-reset-link.email.tsx

lucasbordeau · 2024-01-24T10:13:30Z

Nice work !

martmull · 2024-01-24T12:00:46Z

@i-am-chitti , this diff will fix your tests also

i-am-chitti · 2024-01-24T17:41:14Z

@martmull Thanks for the diff and helping hand. Indeed, feel free to push the changes in PR itself.
Thanks @lucasbordeau for the review. I've pushed changes for PR feedbacks.

I've pushed the diff, but seems there are further tests failing related to emails. Could you have a look once and direct me how to get them fixed?

martmull · 2024-01-25T09:28:16Z

@i-am-chitti thank you for your changes. I have added one last commit to fix the CI (it was an issue with twenty-emails package, not your fault). Think we are able to merge now 🚀. Thank you very much for your contrib, it is really good job. Cheers 🤗

FelixMalfait · 2024-01-26T16:22:32Z

Great work @i-am-chitti !!! Thanks!

i-am-chitti added 29 commits January 10, 2024 00:17

twentyhqGH-3245 add passwordResetToken and passwordResetTokenExpiresA…

1c47a86

…t column on user entity

Add password reset token expiry delay env variable

b3bca79

Add generatePasswordResetToken mutation resolver

a095d3b

Update .env.sample file on server

332a6bf

Add password reset token and expiry migration script

28d56aa

Add validate password reset token query and a dummy password update (…

a822926

…WIP) resolver

Fix bug in password reset token generate

2e3b5ab

Merge branch 'main' into twentyhqGH-3245/password-reset

949ade1

add update password mutation

bd16ea6

Merge branch 'main' into twentyhqGH-3245/password-reset

fe2249d

Update name and add email password reset link

ea035a6

Add change password UI on settings page

a519dd2

Add reset password route on frontend

48b4d04

Add reset password form UI

1e1a82d

Merge branch 'main' into twentyhqGH-3245/password-reset

f5f91e1

sign in user on password reset

dcd3533

format code

fe45e11

make PASSWORD_RESET_TOKEN_EXPIRES_IN optional

f09ebff

add email template for password reset

50bb409

Improve error message

431668f

Rename methods and DTO to improve naming

f2dc994

fix formatting of backend code

7c63e14

Merge branch 'main' into twentyhqGH-3245/password-reset

8ca7d72

Update change password component

ee13204

Update password reset via token component

75ffcbd

update graphql files

fd6f562

spelling fix

2711d36

Make password-reset route authless on frontend

dc34769

show token generation wait time

8075361

martmull requested changes Jan 22, 2024

View reviewed changes

martmull added -PR: awaiting author and removed -PR: awaiting review labels Jan 22, 2024

i-am-chitti added 3 commits January 22, 2024 22:37

Merge branch 'main' into twentyhqGH-3245/password-reset

8fd1073

refactor emails module in reset password

9f498a8

update Graphql generated file

0d292c4

i-am-chitti added 5 commits January 24, 2024 02:57

update email template of password reset

bc217aa

add space between date and text

f359b42

update method name

d482130

Merge branch 'main' into twentyhqGH-3245/password-reset

32c5052

fix lint issues

c743107

i-am-chitti requested a review from martmull January 23, 2024 21:47

martmull requested changes Jan 24, 2024

View reviewed changes

lucasbordeau reviewed Jan 24, 2024

View reviewed changes

packages/twenty-emails/src/emails/password-reset-link.email.tsx Outdated Show resolved Hide resolved

packages/twenty-emails/src/emails/password-reset-link.email.tsx Outdated Show resolved Hide resolved

i-am-chitti added 3 commits January 24, 2024 22:38

Merge branch 'main' into twentyhqGH-3245/password-reset

552426c

remove unused code, fix indentation, and email link color

6a16b2a

update test file for auth and token service

18f6b23

charlesBochet assigned martmull Jan 25, 2024

Fix ci: build twenty-emails when running tests

4f481df

martmull approved these changes Jan 25, 2024

View reviewed changes

martmull merged commit 46f0eb5 into twentyhq:main Jan 25, 2024
10 checks passed

martmull linked an issue Jan 26, 2024 that may be closed by this pull request

Change password from settings #3245

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-3245 Change password from settings page #3538

GH-3245 Change password from settings page #3538

i-am-chitti commented Jan 18, 2024 •

edited

Loading

github-actions bot commented Jan 18, 2024 •

edited

Loading

martmull commented Jan 22, 2024

i-am-chitti commented Jan 23, 2024

i-am-chitti commented Jan 23, 2024

martmull left a comment

lucasbordeau commented Jan 24, 2024

martmull commented Jan 24, 2024

i-am-chitti commented Jan 24, 2024

martmull commented Jan 25, 2024

FelixMalfait commented Jan 26, 2024

GH-3245 Change password from settings page #3538

GH-3245 Change password from settings page #3538

Conversation

i-am-chitti commented Jan 18, 2024 • edited Loading

Description

Issue

Note

Screenshots

Screencast

github-actions bot commented Jan 18, 2024 • edited Loading

martmull commented Jan 22, 2024

i-am-chitti commented Jan 23, 2024

i-am-chitti commented Jan 23, 2024

martmull left a comment

Choose a reason for hiding this comment

lucasbordeau commented Jan 24, 2024

martmull commented Jan 24, 2024

i-am-chitti commented Jan 24, 2024

martmull commented Jan 25, 2024

FelixMalfait commented Jan 26, 2024

i-am-chitti commented Jan 18, 2024 •

edited

Loading

github-actions bot commented Jan 18, 2024 •

edited

Loading