-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3185 / Fix NavigationDrawer Overflow #3187
Conversation
CLA
Hello there and welcome to our project! |
Thanks @jordan-sussman. |
@charlesBochet Hi! That's possible but would prevent users from getting to all sections on shorter viewports. That said, I think this PR is worth fixing the unexpected white space that was initially reported. Separately, it could be worth another ticket to make sections collapsable, but that'd be outside the scope of the initially reported issue. What do you think? |
@jordan-sussman I would give it a try with the ScrollWrapper and with the workspaceName not being scrollable. I think that even with a very small viewport, it should be OK! I've checked many website designs and I don't see any having the whole navbar scrolling! |
@charlesBochet I've moved the overflow attribute to the items container, which fixes the initial issue and the preference to scroll all menu items but not the header workspace name/logo. |
Ok! This looks acceptable, I'll merge it as it is, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Link:
closes #3185
Description:
Fixes a reported issue where short viewports cause the navigation drawer component to overflow past the main table, causing unexpected whitespace when scrolled to the bottom.
Fix:
Adds
overflow-y: auto
toStyledContainer
allowing users to scroll for overflow items and preventing unexpected whitespace.