Added a clear/reset button in InternalDateInput to reset/unschedule events #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbordeau
requested changes
Dec 26, 2023
There was a problem hiding this comment.
Nice implementation, a few minor improvements :
- Vertically center the icon and the "Clear" text
- Add a separating line between the calendar and the new button
- The separating line shouldn't be displayed if we don't set the "clearable" props to true
Figma :
Actual :
...twenty-front/src/modules/ui/input/components/internal/date/components/InternalDatePicker.tsx
Outdated
Show resolved
Hide resolved
...twenty-front/src/modules/ui/input/components/internal/date/components/InternalDatePicker.tsx
Show resolved
Hide resolved
lucasbordeau
requested changes
Dec 26, 2023
...twenty-front/src/modules/ui/input/components/internal/date/components/InternalDatePicker.tsx
Outdated
Show resolved
Hide resolved
...twenty-front/src/modules/ui/input/components/internal/date/components/InternalDatePicker.tsx
Outdated
Show resolved
Hide resolved
...twenty-front/src/modules/ui/input/components/internal/date/components/InternalDatePicker.tsx
Outdated
Show resolved
Hide resolved
...twenty-front/src/modules/ui/input/components/internal/date/components/InternalDatePicker.tsx
Outdated
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lucasbordeau
requested changes
Dec 28, 2023
...twenty-front/src/modules/ui/input/components/internal/date/components/InternalDatePicker.tsx
Show resolved
Hide resolved
| @@ -79,6 +80,8 @@ export const DateInput = ({ | |||
| hotkeyScope, | |||
| }); | |||
|
|
|||
| const { clearable } = useDateTimeField(); | |||
There was a problem hiding this comment.
This call should be made at the DateFieldInput level and drill down the clearable props to DateInput which doesn't know about field related logic.
lucasbordeau
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3086
Changes: Added a clear button to change the value of Date to null also made changes in typeguard functions to accept null as a datetime value
VEED.CREATE.Edit.video.mp4